Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.11: Fix problem where throwing an Error would close connection but send keep-alive #9016

Merged

Conversation

barchetta
Copy link
Member

Description

Backport #9014 to 4.0.11

Resolves #9013

  • ErrorHandlers now handle Throwable instead of just Exception - this is the signature of ErrorHandler and also covers user specific Error classes
  • Http1Connection now sends Connection: close if an exception is caught outside of the handle loop, as the connection is always terminated after this

The second case cannot have an integration test easily written, as it is specifically for handling unexpected exceptions outside of routing.

…end keep-alive (helidon-io#9014)

* Fix wrong keep alive when error happens.

* Error handlers now correctly handle Throwable and not just Exception.
The HTTP/1.1 connection now correctly sends Connection: close header on throwables that cause the connection to be closed.
@barchetta barchetta added webserver backport Issues that are merged into a single branch, but missing in either master or previous release 4.x Version 4.x labels Jul 19, 2024
@barchetta barchetta added this to the 4.0.11 milestone Jul 19, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 19, 2024
@barchetta barchetta merged commit 3325054 into helidon-io:helidon-4.0.11 Jul 19, 2024
12 checks passed
@barchetta barchetta deleted the 4.0.11-9014-connection-close branch November 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x backport Issues that are merged into a single branch, but missing in either master or previous release OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants