Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pandas from 0.19 to 0.21, numpy from 1.16 to 1.16.5 #366

Merged
merged 6 commits into from
Mar 11, 2021

Conversation

chiragjn
Copy link
Contributor

@chiragjn chiragjn commented May 27, 2020

Closes #354
Closes #406

Part of ML-2337

pandas is only used for reading csv files and nothing more
numpy is just patch fixes for security

@srajdev
Copy link
Contributor

srajdev commented May 27, 2020

👍 No lint errors found.

@srajdev
Copy link
Contributor

srajdev commented May 27, 2020

👍 No lint errors found.

@chiragjn
Copy link
Contributor Author

retest this please

@haptik-deployment
Copy link

UNIT TESTS FAILED... Please resolve issues

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #366 (30218f0) into develop (c12bf84) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
+ Coverage    41.03%   41.05%   +0.01%     
===========================================
  Files           91       91              
  Lines         9430     9432       +2     
===========================================
+ Hits          3870     3872       +2     
  Misses        5560     5560              
Impacted Files Coverage Δ
...ors/pattern/phone_number/phone_number_detection.py 85.24% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7408639...30218f0. Read the comment docs.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@chiragjn chiragjn changed the title Bump pandas from 0.19 to 0.21 for faster builds Bump pandas from 0.19 to 0.21, numpy from 1.16 to 1.16.5 Mar 9, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

Copy link

@goru001 goru001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ranvijayj ranvijayj merged commit 2cc48b6 into develop Mar 11, 2021
@chiragjn chiragjn deleted the upgrade_pandas branch April 6, 2021 20:14
@chiragjn chiragjn mentioned this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants