Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to Master Sync #424

Merged
merged 21 commits into from
Apr 9, 2021
Merged

Develop to Master Sync #424

merged 21 commits into from
Apr 9, 2021

Conversation

ankur09011
Copy link
Contributor

@ankur09011 ankur09011 commented Apr 8, 2021 •
edited by chiragjn
Loading

Develop to Master Sync
PRs: #392, #366, #421, #422

chiragjn and others added 21 commits May 27, 2020 19:32
@chiragjn
Bump pandas from 0.19 to 0.21 for faster builds
48ab3fd
@chiragjn
Merge branch 'develop' of https://github.com/hellohaptik/chatbot_ner …
7cd6826 
…into upgrade_pandas
@chiragjn
Merge branch 'develop' of https://github.com/hellohaptik/chatbot_ner …
b712959 
…into upgrade_pandas
This change will help to handle multiple dashes(em dash, en dash and …
8857078 
…hyphen).
This change will help to handle multiple dashes(em dash, en dash and …
083d912 
…hyphen).
@debadityamandal
Handle multiple dashes
9dd49aa
@chiragjn
Merge branch 'develop' into upgrade_pandas
1334960
@debadityamandal
Revert re module
f3be687
@debadityamandal
Merge branch 'develop' into handle_multiple_dashes_phone_number_english
88d630c
@ranvijayj
Merge pull request #392 from debadityamandal/handle_multiple_dashes_p…
7408639 
…hone_number_english

Handle multiple dashes in phone number detection in english
@chiragjn
Merge branch 'develop' into upgrade_pandas
a3bd03e
@chiragjn
Update numpy from 1.16 to 1.16.5
30218f0
@ranvijayj
Merge pull request #366 from hellohaptik/upgrade_pandas
2cc48b6 
Bump pandas from 0.19 to 0.21, numpy from 1.16 to 1.16.5
@chiragjn
fix(search): search on .keyword if search term contain whitespace
799f882
@chiragjn
Merge pull request #421 from hellohaptik/fix_value_whitespace_search
d05f29b 
fix(search): search on .keyword if value search term contains whitespace
@ankur09011
Handle key exceptions and connection error from ES
b93a007
@ankur09011
Handle exception in city API for ES hits and connections
edf89e2
@ankur09011
Add baseclass for Datastore Exceptions.
ecb003d 
For hits miss raised Rwquest Exceptions
@ankur09011
- Modify DataStoreRequestException to add request and response attrib…
516233f 
…ute to catch at root level

- Fix error messages to make it more readble
@ankur09011
remove unused imports from the module
64a4e8c
@ankur09011
Merge pull request #422 from hellohaptik/suuport_for_es_error_status
bd5503f 
Support for better handling error from ES search
@ankur09011 ankur09011 requested a review from chiragjn April 8, 2021 06:14
@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #424 (bd5503f) into master (20df637) will decrease coverage by 0.01%.
The diff coverage is 17.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   41.03%   41.02%   -0.02%     
==========================================
  Files          91       91              
  Lines        9430     9433       +3     
==========================================
  Hits         3870     3870              
- Misses       5560     5563       +3
Impacted Files Coverage Δ
datastore/elastic_search/query.py 0.00% <0.00%> (ø)
datastore/exceptions.py 0.00% <0.00%> (ø)
ner_v2/detectors/textual/queries.py 94.64% <ø> (ø)
ner_v1/api.py 22.60% <9.09%> (-1.21%) ⬇️
ner_v2/api.py 13.04% <14.28%> (+0.10%) ⬆️
ner_v2/detectors/textual/elastic_search.py 64.04% <14.28%> (-3.02%) ⬇️
ner_v2/detectors/textual/utils.py 87.14% <78.57%> (+1.24%) ⬆️
...ors/pattern/phone_number/phone_number_detection.py 85.24% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20df637...bd5503f. Read the comment docs.

@ankur09011 ankur09011 merged commit ffe639a into master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragjn chiragjn chiragjn approved these changes

Assignees
No one assigned
Labels
bug-fixes enhancement No lint errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankur09011 @haptik-deployment @chiragjn @debadityamandal @ranvijayj