Support for better handling error from ES search #422
Conversation
|
👍 No lint errors found. |
ankur09011
force-pushed
the
suuport_for_es_error_status
branch
from
2577321 to
8c291ac
Compare
|
👍 No lint errors found. |
|
UNIT TESTS HAVE PASSED... Good To Merge |
Codecov Report
@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
- Coverage 41.03% 41.02% -0.01%
===========================================
Files 91 91
Lines 9436 9433 -3
===========================================
- Hits 3872 3870 -2
+ Misses 5564 5563 -1
Continue to review full report at Codecov.
|
ankur09011
force-pushed
the
suuport_for_es_error_status
branch
from
8c291ac to
b93a007
Compare
|
👍 No lint errors found. |
ankur09011
changed the title
|
👍 No lint errors found. |
|
UNIT TESTS HAVE PASSED... Good To Merge |
For hits miss raised Rwquest Exceptions
|
👍 No lint errors found. |
|
UNIT TESTS HAVE PASSED... Good To Merge |
ner_v1/api.py
Outdated
| except TypeError as err: | ||
| ner_logger.exception(f"Error in text_synonym for: {request.path}, error: {err}") | ||
| return HttpResponse(status=500) | ||
| except KeyError as err: | ||
| ner_logger.exception(f"Error in text_synonym for: {request.path}, error: {err}") | ||
| return HttpResponse(status=500) | ||
| except es_exceptions.ConnectionTimeout as err: | ||
| ner_logger.exception(f"Error in text_synonym for: {request.path}, error: {err}") | ||
| return HttpResponse(status=500) | ||
| except es_exceptions.ConnectionError as err: | ||
| ner_logger.exception(f"Error in text_synonym for: {request.path}, error: {err}") | ||
| return HttpResponse(status=500) |
There was a problem hiding this comment.
Minor, considering we are doing the exact same thing we can combine the blocks
except (TypeError, KeyError, ...) as err
| except TypeError as e: | ||
| ner_logger.exception('Exception for city: %s ' % e) | ||
| return HttpResponse(status=500) | ||
| except KeyError as e: | ||
| ner_logger.exception('Exception for text_synonym: %s ' % e) | ||
| return HttpResponse(status=500) | ||
| except es_exceptions.ConnectionTimeout as e: | ||
| ner_logger.exception('Exception for text_synonym: %s ' % e) | ||
| return HttpResponse(status=500) | ||
| except es_exceptions.ConnectionError as e: | ||
| ner_logger.exception('Exception for text_synonym: %s ' % e) | ||
| return HttpResponse(status=500) |
There was a problem hiding this comment.
Added some more suggestions, please verify it will be easy to grep the Datastore exception cases along with the queries and the responses from logs because without structured logging multiline logs (like tracebacks) from multiple parallel workers can get entangled and hard to decipher
…ute to catch at root level - Fix error messages to make it more readble
|
👍 No lint errors found. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
UNIT TESTS HAVE PASSED... Good To Merge |
JIRA Ticket Number
JIRA TICKET: ML-2249
Description of change
Adding support for handling exceptions raised from ES for:
Checklist (OPTIONAL):