Handle multiple dashes in phone number detection in english

[debadityamandal]

This commit will replace em-dash and en-dash with hyphen which will help us to find the locale easily in phone number. Since all dashes look like same, we can't separate them by any expression because except hyphen another dashes are not available in keyboard but their unicode values are different. To do this I replaced re module by regex module.

[haptik-unit-test]

Can one of the admins verify this patch?

[haptik-deployment]

👍 No lint errors found.

[chiragjn]

Hello, thank you for your contribution. Sorry for the late reply 😅
Can you please give us an example case of locale where such kind of substitution is needed?
Since locale is supposed to be passed from the outside, we would normally expect it to be correct

[debadityamandal]

I was using this module to extract phone number from few documents. That time I got locale "EN–US" from those documents and I got the following response-
([{'country_calling_code': '91', 'value': 'XXXXXXXXXX'}], ['XXXXXXXXXX'])
This 'country_calling_code' is representing India but I gave US. Then I started to debug the code and I saw it was not detecting country code because of the wrong dash as the code is detecting only hyphen. We can't type Em-Dash/En-Dash through keyboard normally. So, I converted the Em-Dash which is mentioned in locale to hyphen and now I am getting following response-
([{'country_calling_code': '1', 'value': 'XXXXXXXXXX'}], ['XXXXXXXXXX']).

[chiragjn]

Although this seems like something that should be handled outside of this module, I am still willing to accept the change. Can you please revert all re changes? We would like to use both re and regex (only for the dash replacing use cases) for now to keep the diff as small as possible

[haptik-deployment]

👍 No lint errors found.

[debadityamandal]

I revert all re changes. Please let me know if you have any doubt.

[haptik-deployment]

👍 No lint errors found.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[debadityamandal]

Thank you for accepting my code. I am closing pull request