Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release drafter to enable Miscellaneous label as a normal category #391

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

ranvijayj
Copy link
Collaborator

@ranvijayj ranvijayj commented Jan 11, 2021

JIRA Ticket Number

JIRA TICKET: ADO-4873

Description of change

Updated release drafter to enable Miscellaneous label as a normal category
Removed miscellaneous from exclude-labels

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…egory

Updated release drafter to enable Miscellaneous label as a normal category 
Removed miscellaneous from exclude-labels
JIRA TICKET: ADO-4873
@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #391 (5e63269) into develop (c5339ce) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #391      +/-   ##
===========================================
+ Coverage    71.16%   71.19%   +0.03%     
===========================================
  Files           78       78              
  Lines         5777     5777              
===========================================
+ Hits          4111     4113       +2     
+ Misses        1666     1664       -2     
Impacted Files Coverage Δ
...er_v2/detectors/temporal/date/en/date_detection.py 57.99% <0.00%> (+0.12%) ⬆️
...r_v2/tests/temporal/date/en/test_date_detection.py 100.00% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dffbf6...5e63269. Read the comment docs.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chiragjn chiragjn merged commit ad86335 into develop Mar 2, 2021
@chiragjn chiragjn deleted the ranvijayj-patch-1 branch June 18, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants