Develop to Master 2021-03-04T13:57:00 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egory Updated release drafter to enable Miscellaneous label as a normal category Removed miscellaneous from exclude-labels JIRA TICKET: ADO-4873
Add elastic APM config changes
Add elastic apm to list of packages
Update service name in apm code
Configure WhiteSource Bolt for GitHub
Updated settings.py with requested changes
Updated release drafter to enable Miscellaneous label as a normal category
- Fix http response code for internal server errors for v2/text - Fix false positive number detection in time detection. Demand a separator for such cases e.g. fail on "145", e.g. "1:45" - Update sentry-sdk (and refactor requirements.txt) - Drop unused static html, js, css files to resolve CVE issues - Fix IndexError for v1/person_name - Allow bot message check in person_name to be skipped if data for a language is missing - Refactor person_name detector code for multi-lingual
it Also, change logging formatter, drop NLPLogger, and update setup_sentry
uncomment lot of tests
Add elastic APM config changes
Bug fixes for v2/number, v2/number_range, v2/time
|
👍 No lint errors found. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
UNIT TESTS HAVE PASSED... Good To Merge |
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
===========================================
- Coverage 71.16% 41.02% -30.14%
===========================================
Files 78 91 +13
Lines 5777 9428 +3651
===========================================
- Hits 4111 3868 -243
- Misses 1666 5560 +3894
Continue to review full report at Codecov.
|
ankur09011
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs: #391, #395, #393, #416