Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elastic APM config changes #393

Merged
merged 6 commits into from
Mar 3, 2021
Merged

Add elastic APM config changes #393

merged 6 commits into from
Mar 3, 2021

Conversation

minion96
Copy link
Contributor

JIRA Ticket Number

JIRA TICKET: ADO-5048

Description of change

Add code for elastic APM integration

Checklist:

  • List of all ENV's needed
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@minion96
Add elastic APM config changes
b21d6e0 
Add elastic APM config changes
@haptik-deployment
Copy link

👍 No lint errors found.

@minion96
Add elastic apm to requirements
b380c97 
Add elastic apm to list of packages
@haptik-deployment
Copy link

👍 No lint errors found.

@minion96
Update service name in apm code
cfd50a0 
Update service name in apm code
@haptik-deployment
Copy link

👍 No lint errors found.

chiragjn
chiragjn reviewed Feb 19, 2021
View reviewed changes
chatbot_ner/settings.py Outdated Show resolved Hide resolved
chiragjn
chiragjn reviewed Feb 19, 2021
View reviewed changes
chatbot_ner/settings.py Outdated Show resolved Hide resolved
chiragjn
chiragjn reviewed Feb 19, 2021
View reviewed changes
chatbot_ner/settings.py Outdated Show resolved Hide resolved
chiragjn
chiragjn suggested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@chiragjn chiragjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting minor changes

@haptik-deployment
Copy link

👍 No lint errors found.

@minion96
Updated settings.py with requested changes
4f8e8e8 
Updated settings.py with requested changes
@haptik-deployment
Copy link

👍 No lint errors found.

@minion96
Copy link
Contributor Author

Retest this please

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ranvijayj ranvijayj merged commit 5a17e27 into hellohaptik:develop Mar 3, 2021
@chiragjn chiragjn mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragjn chiragjn chiragjn approved these changes

Assignees
No one assigned
Labels
enhancement No lint errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minion96 @haptik-deployment @chiragjn @ranvijayj