-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for v2/number, v2/number_range, v2/time #416
Conversation
- Fix http response code for internal server errors for v2/text - Fix false positive number detection in time detection. Demand a separator for such cases e.g. fail on "145", e.g. "1:45" - Update sentry-sdk (and refactor requirements.txt) - Drop unused static html, js, css files to resolve CVE issues - Fix IndexError for v1/person_name - Allow bot message check in person_name to be skipped if data for a language is missing - Refactor person_name detector code for multi-lingual
it Also, change logging formatter, drop NLPLogger, and update setup_sentry
uncomment lot of tests
👍 No lint errors found. |
UNIT TESTS FAILED... Please resolve issues |
👍 No lint errors found. |
👍 No lint errors found. |
👍 No lint errors found. |
UNIT TESTS HAVE PASSED... Good To Merge |
Codecov Report
@@ Coverage Diff @@
## develop #416 +/- ##
============================================
- Coverage 71.19% 41.02% -30.17%
============================================
Files 78 91 +13
Lines 5777 9428 +3651
============================================
- Hits 4113 3868 -245
- Misses 1664 5560 +3896
Continue to review full report at Codecov.
|
👍 No lint errors found. |
UNIT TESTS HAVE PASSED... Good To Merge |
👍 No lint errors found. |
UNIT TESTS HAVE PASSED... Good To Merge |
👍 No lint errors found. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
JIRA Ticket Number
JIRA TICKET: BB-3339, ML-2316, ML-766, ML-2289, ML-2325
Description of change
ner_v2/api.py
Closes: #372
Closes: #397
Closes: #399
Closes: #400
Closes: #401
Closes: #402
Closes: #403
Closes: #404
Closes: #410
Closes: #411
Checklist (OPTIONAL):