Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to Master: September 19 #441

Merged
merged 14 commits into from
Sep 29, 2021
Merged

Develop to Master: September 19 #441

merged 14 commits into from
Sep 29, 2021

Conversation

tanaya-b
Copy link
Contributor

@tanaya-b tanaya-b commented Sep 29, 2021

Develop to Master
PRs
#436
#418
#440

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #441 (ef5c66f) into master (3ffa88b) will increase coverage by 0.75%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   41.21%   41.96%   +0.75%     
==========================================
  Files          91       79      -12     
  Lines        9456     8869     -587     
==========================================
- Hits         3897     3722     -175     
+ Misses       5559     5147     -412     
Impacted Files Coverage Δ
external_api/api.py 15.71% <ø> (+1.25%) ⬆️
external_api/constants.py 0.00% <ø> (ø)
ner_v1/api.py 22.60% <ø> (ø)
ner_v1/constant.py 100.00% <ø> (ø)
ner_v1/detectors/textual/name/lang_constants.py 100.00% <ø> (ø)
ner_v1/chatbot/entity_detection.py 21.60% <40.00%> (+0.26%) ⬆️
ner_v1/detectors/temporal/date/date_detection.py 7.95% <66.66%> (-0.17%) ⬇️
ner_v1/detectors/textual/city/city_detection.py 15.90% <75.00%> (+0.01%) ⬆️
ner_v2/detectors/temporal/date/date_detection.py 63.09% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffa88b...ef5c66f. Read the comment docs.

@tanaya-b tanaya-b merged commit a29f487 into master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants