Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused crf code #418

Merged
merged 8 commits into from
Sep 21, 2021
Merged

Removed unused crf code #418

merged 8 commits into from
Sep 21, 2021

Conversation

chiragjn
Copy link
Contributor

@chiragjn chiragjn commented Mar 4, 2021

JIRA Ticket Number

JIRA TICKET: ML-1504

Description of change

Remove older CRF models code that is not being used

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.3% 8.3% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #418 (4bf32e8) into develop (36385b1) will increase coverage by 0.75%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
+ Coverage    41.21%   41.96%   +0.75%     
===========================================
  Files           91       79      -12     
  Lines         9456     8869     -587     
===========================================
- Hits          3897     3722     -175     
+ Misses        5559     5147     -412     
Impacted Files Coverage Δ
external_api/api.py 15.71% <ø> (+1.25%) ⬆️
external_api/constants.py 0.00% <ø> (ø)
ner_v1/api.py 22.60% <ø> (ø)
ner_v1/constant.py 100.00% <ø> (ø)
ner_v1/chatbot/entity_detection.py 21.60% <40.00%> (+0.26%) ⬆️
ner_v1/detectors/temporal/date/date_detection.py 7.95% <66.66%> (-0.17%) ⬇️
ner_v1/detectors/textual/city/city_detection.py 15.90% <75.00%> (+0.01%) ⬆️
ner_v2/detectors/temporal/date/date_detection.py 63.09% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc39f7...4bf32e8. Read the comment docs.

…into removed_unused_crf_code

Merge origin/develop into current branch and resolve conflicts
@haptik-deployment
Copy link

👍 No lint errors found.

@SinghDivneet
Copy link
Contributor

Retest this please

2 similar comments
@ranvijayj
Copy link
Collaborator

Retest this please

@ranvijayj
Copy link
Collaborator

Retest this please

Update git ignore alphabet case for C extenstion
@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.3% 8.3% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@chiragjn chiragjn merged commit 72a48c8 into develop Sep 21, 2021
@chiragjn chiragjn deleted the removed_unused_crf_code branch October 20, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants