Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

stable/prometheus-operator duplicate annotations #20544

Closed
slimm609 opened this issue Feb 4, 2020 · 0 comments · Fixed by #20545
Closed

stable/prometheus-operator duplicate annotations #20544

slimm609 opened this issue Feb 4, 2020 · 0 comments · Fixed by #20545

Comments

@slimm609
Copy link
Contributor

slimm609 commented Feb 4, 2020

A recent commit added duplicate annotations to the prometheus-operator helm chart.

f47e033#diff-db169087d4cd64dbed827ce125e7f555

This caused the yaml to not be validated because of it annotations already being declared on the CRDs. This also broke the ability to run prometheus-operator through ship.
slimm609 pushed a commit to slimm609/charts that referenced this issue Feb 4, 2020
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
8cc1ce1 
…elm#20544)

    * remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>
@slimm609 slimm609 mentioned this issue Feb 4, 2020
Merged
3 tasks
slimm609 pushed a commit to slimm609/charts that referenced this issue Feb 4, 2020
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
ba7231c 
…elm#20544)

    * remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
@jbfavre jbfavre mentioned this issue Feb 6, 2020
Closed
k8s-ci-robot pushed a commit that referenced this issue Feb 19, 2020
@slimm609
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (#…
1ffd255 
…20544) (#20545)

* remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this issue Jul 29, 2020
@slimm609 @li-adrienloiseau
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
b2276b5 
…elm#20544) (helm#20545)

* remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this issue Aug 28, 2020
@slimm609
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
21e19f7 
…elm#20544) (helm#20545)

* remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (#20544) slimm609/charts
1 participant
@slimm609