Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (#20544) #20545

Merged
merged 1 commit into from
Feb 19, 2020
Merged

[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (#20544) #20545

merged 1 commit into from
Feb 19, 2020

Conversation

slimm609
Copy link
Contributor

@slimm609 slimm609 commented Feb 4, 2020

Is this a new chart

No

What this PR does / why we need it:

Duplicate Annotations were added during a recent commit causing failures in yaml validation.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @slimm609. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2020
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
ba7231c 
…elm#20544)

    * remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 4, 2020
@vsliouniaev
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slimm609, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@slimm609
Copy link
Contributor Author

slimm609 commented Feb 4, 2020

/retest

@slimm609
Copy link
Contributor Author

slimm609 commented Feb 4, 2020

This looks like the cluster can't schedule the pods, I don't see any errors related to the chart.

@sc2borges sc2borges mentioned this pull request Feb 4, 2020
Merged
4 tasks
@vsliouniaev
Copy link
Collaborator

/retest

6 similar comments
@slimm609
Copy link
Contributor Author

slimm609 commented Feb 6, 2020

/retest

@slimm609
Copy link
Contributor Author

slimm609 commented Feb 7, 2020

/retest

@vsliouniaev
Copy link
Collaborator

/retest

@vsliouniaev
Copy link
Collaborator

/retest

@slimm609
Copy link
Contributor Author

/retest

@unguiculus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ffd255 into helm:master Feb 19, 2020
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@slimm609 @li-adrienloiseau
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
b2276b5 
…elm#20544) (helm#20545)

* remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@slimm609
[stable/prometheus-operator] Remove Duplicate Annotations from CRDs (h…
21e19f7 
…elm#20544) (helm#20545)

* remove duplicate CRDs from annotations on prometheus-operator.

    Signed-off-by: Brian Davis <slimm609@gmail.com>

Signed-off-by: Brian Davis <brian.davis@ciphertrace.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bismarck bismarck Awaiting requested review from bismarck

@vsliouniaev vsliouniaev Awaiting requested review from vsliouniaev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stable/prometheus-operator duplicate annotations
5 participants
@slimm609 @k8s-ci-robot @vsliouniaev @unguiculus @helm-bot