-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[Tests] update docs, avoid redirect and fix dead link #14828
Conversation
Signed-off-by: Asher Foa <asher@asherfoa.com>
Hi @asherf. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @paulczar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asherf!
/ok-to-test
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asherf, jlegrone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Asher Foa <asher@asherfoa.com> Signed-off-by: Nigel Foucha <nigel.foucha@gmail.com>
Signed-off-by: Asher Foa <asher@asherfoa.com> Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
The chart_test.sh was rewritten in go (yay!) so this update reflects that.
see helm/chart-testing#35
@unguiculus FYI
Signed-off-by: Asher Foa asher@asherfoa.com
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]