Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[Tests] update docs, avoid redirect and fix dead link #14828

Merged
merged 1 commit into from
Jun 16, 2019
Merged

[Tests] update docs, avoid redirect and fix dead link #14828

merged 1 commit into from
Jun 16, 2019

Conversation

asherf
Copy link
Collaborator

@asherf asherf commented Jun 15, 2019

The chart_test.sh was rewritten in go (yay!) so this update reflects that.
see helm/chart-testing#35
@unguiculus FYI

Signed-off-by: Asher Foa asher@asherfoa.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Signed-off-by: Asher Foa <asher@asherfoa.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from jlegrone and maorfr June 15, 2019 22:24
@k8s-ci-robot
Copy link
Contributor

Hi @asherf. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2019
@asherf
Copy link
Collaborator Author

asherf commented Jun 15, 2019

/assign @paulczar

Copy link
Member

@jlegrone jlegrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asherf!

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2019
@jlegrone
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asherf, jlegrone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 17f24c2 into helm:master Jun 16, 2019
fooka03 pushed a commit to fooka03/charts that referenced this pull request Jun 17, 2019
Signed-off-by: Asher Foa <asher@asherfoa.com>
Signed-off-by: Nigel Foucha <nigel.foucha@gmail.com>
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
Signed-off-by: Asher Foa <asher@asherfoa.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants