Re-write it in Go

[unguiculus]

I built a first beta release on my own fork. For this initial release I put the focus on more or less keeping the same functionality, but configuration is much more flexible now. Once we get this merged, we can look at new features such as integrating additional tools like Kubeval or better reporting capabilities.

Please review and test.

https://github.com/unguiculus/chart-testing/releases/tag/v2.0.0-beta.0

@helm/charts-maintainers

[scottrigby]

I've looked at this on your fork and it's great 👏 I plan to dig into this in more depth soon

For anyone who wants more context, see #29

[rimusz]

awesome work @unguiculus 👍 I will give a go for test

[unguiculus]

Here's a test PR that updates charts CI in order to demonstrate it works as expected:
helm/charts#8745

[rimusz]

would be nice to put to readme flags for lint, install, lint-and-install:

$ ./ct lint-and-install -h

Combines 'lint' and 'install' commands.

Usage:
  ct lint-and-install [flags]

Flags:
      --all                        Process all charts except those explicitly excluded.
                                   Disables changed charts detection and version increment checking
      --build-id string            An optional, arbitrary identifier that is added to the name of the namespace a
                                   chart is installed into. In a CI environment, this could be the build number or
                                   the ID of a pull request. If not specified, the name of the chart is used.
      --chart-dirs strings         Directories containing Helm charts (default [charts])
      --chart-repos strings        Additional chart repos to add so dependencies can be resolved
      --chart-yaml-schema string   The schema for chart.yml validation. If not specified, 'chart_schema.yaml'
                                   is searched in '/etc/ct', '$HOME/ct' and the current directory
      --charts strings             Specific charts to test.
                                   Disables changed charts detection and version increment checking
      --check-version-increment    Activates a check for chart version increments (default: true) (default true)
      --config string              Config file
      --excluded-charts strings    Charts that should be skipped
  -h, --help                       help for lint-and-install
      --lint-conf string           The config file for YAML linting. If not specified, 'lintconf.yaml' is
                                   searched in '/etc/ct', '$HOME/ct' and the current directory
      --remote string              The name of the Git remote used to identify changed charts (default "origin")
      --target-branch string       The name of the target branch used to identify changed charts (default "master")
      --tiller-namespace string    The namespace of Tiller (default: kube-system) (default "kube-system")
      --timeout duration           The timeout for Helm in seconds (default: 5m) (default 5m0s)
      --validate-maintainers       Enabled validation of maintainer account names in chart.yml (default: true).
                                   Works for GitHub, GitLab, and Bitbucket (default true)

So you do. to have to run commands yourself to check that out.

[unguiculus]

@rimusz I wasn't sure whether we should do that. I thought that might be too much. What does everyone else think?

[rimusz]

e.g. to add a folder docs and there to store more detailed info.

[mattfarina]

Nice job on the re-write. I like the direction. On the whole it LGTM. Because of the size I gave it a relatively fast review (~1 hour) for the size. There is a lot here.

[mattfarina]

I see for the format for ChartRepos is incubator=https://incubator. Would it be more intuitive if those were broken up? Then the YAML would look something like:

chart-repos:
  - name: incubator
    location: https://incubator

[unguiculus]

All Cobra CLI flags are bound to Viper. This is generic. I guess changing this is not easily possible. And it would not be consistent.

[unguiculus]

Next beta: https://github.com/unguiculus/chart-testing/releases/tag/v2.0.0-beta.2

[scottrigby]

#35 (comment) and #35 (comment) have been addressed. README has been clarified on that point. File inclusion looks good in the new beta now too 💯

$ tree
.
├── LICENSE
├── README.md
├── ct
└── etc
    ├── chart_schema.yaml
    └── lintconf.yaml

1 directory, 5 files

[mattfarina]

This looks good to merge. Any future changes or fixes can come in smaller PRs.

Nicely done @unguiculus. This rewrite was a massive undertaking and you make it look easier than I could have.

[prydonius]

I had a very quick look through, and it's looking pretty solid to me. I'm not sure if you considered it, but we could import the Helm API for some of the structs we're using rather than duplicate them here, but that's a minor issue and we may want to have control over those structs here.

[scottrigby]

We've had all eyes on this, and it has been tested extensively now. Merging!