Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[test] Update chart testing #8745

Merged
merged 1 commit into from
Nov 7, 2018
Merged

[test] Update chart testing #8745

merged 1 commit into from
Nov 7, 2018

Conversation

unguiculus
Copy link
Member

@unguiculus unguiculus commented Oct 25, 2018 •
edited
Loading

No description provided.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 6ee8090 to 557cfbc Compare October 25, 2018 13:30
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 557cfbc to d737d5d Compare October 25, 2018 13:51
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2018
@unguiculus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from d737d5d to 1822539 Compare October 25, 2018 13:54
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 1822539 to 142aae9 Compare October 25, 2018 14:08
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2018
@unguiculus unguiculus mentioned this pull request Oct 25, 2018
Merged
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 2cb7fbc to a3277ff Compare November 6, 2018 20:37
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from a3277ff to d89d7b6 Compare November 6, 2018 20:41
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2018
@scottrigby
Copy link
Member

For reference: helm/chart-testing#35

@unguiculus unguiculus force-pushed the update-chart-testing branch from d89d7b6 to c062bc8 Compare November 7, 2018 19:07
@unguiculus unguiculus force-pushed the update-chart-testing branch from a8eda69 to 9f9a7d4 Compare November 7, 2018 19:12
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 9f9a7d4 to bfdfcb1 Compare November 7, 2018 19:13
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2018
@unguiculus unguiculus changed the title [WIP] Update chart testing [test] Update chart testing Nov 7, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from bfdfcb1 to 7aa84e8 Compare November 7, 2018 19:41
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from 7aa84e8 to a7fec78 Compare November 7, 2018 19:54
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2018
@unguiculus unguiculus force-pushed the update-chart-testing branch from a7fec78 to 1b47567 Compare November 7, 2018 19:57
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2018
@unguiculus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2018
@unguiculus
[test] Update to chart-testing v2.0.0
7a47d05 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@unguiculus unguiculus force-pushed the update-chart-testing branch from 1b47567 to 7a47d05 Compare November 7, 2018 20:30
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2018
@scottrigby
Copy link
Member

The circle jobs were waiting earlier due to a github webhook brownout:
screen shot 2018-11-07 at 4 57 19 pm

So I resent the webhook, and now lint-charts and lint-scripts passed 👍

@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scottrigby, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [scottrigby,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 408a5ab into helm:master Nov 7, 2018
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@unguiculus @wgiddens
[test] Update to chart-testing v2.0.0 (helm#8745)
7f614d3 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattfarina mattfarina Awaiting requested review from mattfarina

@paulczar paulczar Awaiting requested review from paulczar

Assignees

@scottrigby scottrigby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unguiculus @scottrigby @k8s-ci-robot @helm-bot