Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/spinnaker] bump spinnaker and requirement versions #15216

Closed
wants to merge 1 commit into from

Conversation

vchrisb
Copy link
Contributor

@vchrisb vchrisb commented Jul 2, 2019

chart version 1.14.0

spinnaker 1.12.5 -> 1.14.8
redis 3.8.0 -> 8.0.14
minio 1.6.3 -> 2.4.16

Fixed specifying minio image tag in values.yml but uncommented it as the default is inherited by the requirements.

Tested on Kubernetes 1.13.5 and Helm 2.14.1

Signed-off-by: Christopher Banck cbanck@pivotal.io

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

chart version 1.13.2

spinnaker 1.12.5 -> 1.14.8
redis 3.8.0 -> 8.0.14
minio 1.6.3 -> 2.4.16

fixed specifying minio image tag in values.yml

Signed-off-by: Christopher Banck <cbanck@pivotal.io>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @vchrisb. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vchrisb
To complete the pull request process, please assign lwander
You can assign the PR to them by writing /assign @lwander in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dwardu89 and paulczar July 2, 2019 17:44
@paulczar
Copy link
Collaborator

paulczar commented Jul 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2019
@paulczar
Copy link
Collaborator

paulczar commented Jul 2, 2019

/hold

The spinnaker updates themselves are fine, however the minio and redis dependency changes causes failures if a user runs helm dependency update and then attempts to upgade their spinnaker.

helm dependency update
Hang tight while we grab the latest from your chart repositories...
...
Update Complete.
Saving 2 charts
Downloading redis from repo https://kubernetes-charts.storage.googleapis.com/
Downloading minio from repo https://kubernetes-charts.storage.googleapis.com/
Deleting outdated charts
$  helm upgrade spin1 . --timeout 600                      
UPGRADE FAILED
Error: PersistentVolumeClaim "spin1-minio" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims && Service "spin1-minio" is invalid: spec.clusterIP: Invalid value: "": field is immutable && StatefulSet.apps "spin1-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden
Error: UPGRADE FAILED: PersistentVolumeClaim "spin1-minio" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims && Service "spin1-minio" is invalid: spec.clusterIP: Invalid value: "": field is immutable && StatefulSet.apps "spin1-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2019
@vchrisb
Copy link
Contributor Author

vchrisb commented Jul 2, 2019

thank you, I'll look into it.

@vchrisb
Copy link
Contributor Author

vchrisb commented Jul 9, 2019

@paulczar the issue is, that the minio chart had in 1.6.3 the clusterip set to None, which is called a headless service in kubernetes. This changes in 1.6.4, where the chart removed that.
43e7da2#diff-d07642008f9bb427a35e5d86bdae6b14
I'll add service.clusterIP: None to keep on using headless and let the upgrade succeed.
I also opened an issue (#15341) for the minio chart to fix that issue and also allow to remove headless by settting service.clusterIP: null

@vchrisb
Copy link
Contributor Author

vchrisb commented Jul 9, 2019

for redis it looks like there is a manual process required to upgrade: https://github.com/helm/charts/tree/master/stable/redis#400
This is due to #7726
Any idea how to handle that with the spinnaker chart? Also adding an upgrade note here and make it a breaking change?

@paulczar
Copy link
Collaborator

If redis makes it a breaking change, can we bump without upgrading it? If not then we need to do a full version bump and provide upgrade doc

@ramonskie
Copy link

would also be nice if we can use the latest stable hal version
by using tag halyard.image.tag=stable in values.yaml

@stale
Copy link

stale bot commented Aug 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2019
@stale
Copy link

stale bot commented Sep 5, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants