-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/spinnaker] bump spinnaker and requirement versions #15216
Conversation
chart version 1.13.2 spinnaker 1.12.5 -> 1.14.8 redis 3.8.0 -> 8.0.14 minio 1.6.3 -> 2.4.16 fixed specifying minio image tag in values.yml Signed-off-by: Christopher Banck <cbanck@pivotal.io>
Hi @vchrisb. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vchrisb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/hold The spinnaker updates themselves are fine, however the minio and redis dependency changes causes failures if a user runs helm dependency update
Hang tight while we grab the latest from your chart repositories...
...
Update Complete.
Saving 2 charts
Downloading redis from repo https://kubernetes-charts.storage.googleapis.com/
Downloading minio from repo https://kubernetes-charts.storage.googleapis.com/
Deleting outdated charts
$ helm upgrade spin1 . --timeout 600
UPGRADE FAILED
Error: PersistentVolumeClaim "spin1-minio" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims && Service "spin1-minio" is invalid: spec.clusterIP: Invalid value: "": field is immutable && StatefulSet.apps "spin1-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden
Error: UPGRADE FAILED: PersistentVolumeClaim "spin1-minio" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims && Service "spin1-minio" is invalid: spec.clusterIP: Invalid value: "": field is immutable && StatefulSet.apps "spin1-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden
|
thank you, I'll look into it. |
@paulczar the issue is, that the minio chart had in |
for redis it looks like there is a manual process required to upgrade: https://github.com/helm/charts/tree/master/stable/redis#400 |
If redis makes it a breaking change, can we bump without upgrading it? If not then we need to do a full version bump and provide upgrade doc |
would also be nice if we can use the latest stable hal version |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
chart version 1.14.0
spinnaker 1.12.5 -> 1.14.8
redis 3.8.0 -> 8.0.14
minio 1.6.3 -> 2.4.16
Fixed specifying minio image tag in values.yml but uncommented it as the default is inherited by the requirements.
Tested on Kubernetes 1.13.5 and Helm 2.14.1
Signed-off-by: Christopher Banck cbanck@pivotal.io
Checklist
[stable/chart]
)