Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add annotation support to pushgateway service #20351

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Add annotation support to pushgateway service #20351

merged 3 commits into from
Jan 31, 2020

Conversation

jmccarty3
Copy link
Contributor

Signed-off-by: Justin McCarty justin.mccarty@syapse.com

Re-Opening this as the other was closed (#15982) and I do not have permissions to re-open closed PRs

Adds support for service annotations to the prometheus push gateway service. Annotations can be utilized to expose the push gateway outside of the cluster with an internal ELB.

@jmccarty3
Add annotation support to pushgateway service
92be3cf 
Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jmccarty3. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmccarty3
Copy link
Contributor Author

@cstaud @gianrubio Can I get a review on this please?

@k8s-ci-robot
Copy link
Contributor

@zanhsieh: GitHub didn't allow me to assign the following users: cancel.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh zanhsieh removed their assignment Jan 27, 2020
Aisuko
Aisuko suggested changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kindly check the issue below.

stable/prometheus-pushgateway/templates/service.yaml Outdated Show resolved Hide resolved
@Aisuko
Copy link
Collaborator

Aisuko commented Jan 27, 2020

/assign @cstaud

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 27, 2020
@jmccarty3
Correct value for service annotations
ef86b23 
Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>
@jmccarty3 jmccarty3 force-pushed the push-gateway-annotations branch from 0edd5e8 to ef86b23 Compare January 27, 2020 13:45
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 27, 2020
@jmccarty3 jmccarty3 requested review from Aisuko and cstaud January 27, 2020 17:45
@Aisuko
Copy link
Collaborator

Aisuko commented Jan 28, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2020
Aisuko
Aisuko approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@Aisuko Aisuko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Aisuko
Copy link
Collaborator

Aisuko commented Jan 28, 2020

Thanks, please help to merge the PR. @cstaud

@cstaud
Copy link
Contributor

cstaud commented Jan 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aisuko, cstaud, jmccarty3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@cstaud
Copy link
Contributor

cstaud commented Jan 31, 2020

Thank you! @jmccarty3 👍

@k8s-ci-robot k8s-ci-robot merged commit 665fbdc into helm:master Jan 31, 2020
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 3, 2020
@jmccarty3
Add annotation support to pushgateway service (helm#20351)
3a7ddb7 
* Add annotation support to pushgateway service

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>

* Correct value for service annotations

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>

Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 4, 2020
@jmccarty3
Add annotation support to pushgateway service (helm#20351)
23d81e4 
* Add annotation support to pushgateway service

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>

* Correct value for service annotations

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>
Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@jmccarty3
Add annotation support to pushgateway service (helm#20351)
fb68015 
* Add annotation support to pushgateway service

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>

* Correct value for service annotations

Signed-off-by: Justin McCarty <justin.mccarty@syapse.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aisuko Aisuko Aisuko approved these changes

@sstarcher sstarcher sstarcher approved these changes

@gianrubio gianrubio Awaiting requested review from gianrubio

@cstaud cstaud Awaiting requested review from cstaud

Assignees

@cstaud cstaud

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmccarty3 @k8s-ci-robot @Aisuko @cstaud @sstarcher @zanhsieh @helm-bot