This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/redis] Allow DNS egress to resolve hostnames #20437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @glentakahashi. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
glentakahashi
force-pushed
the
patch-1
branch
from
37eaa3f to
0622459
Compare
helm-bot
added
the
Contribution Allowed
glentakahashi
changed the title
Signed-off-by: Glen Takahashi <glen@glentaka.com>
glentakahashi
force-pushed
the
patch-1
branch
from
0622459 to
e2c3b65
Compare
juan131
approved these changes
Jan 31, 2020
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
lgtm
|
There was a new release while testing your PR. Could you please rebase your branch from master and update the PR? Thanks in advance. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glentakahashi, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MarcusSorealheis
added a commit
to MarcusSorealheis/charts
that referenced
this pull request
Feb 4, 2020
…tainer * upstream/master: (309 commits) [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523) [stable/prometheus-redis-exporter] Update image for exporter (helm#19317) update alantis version (helm#20507) [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517) [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409) Allow DNS egress to resolve hostnames (helm#20437) [stable/rabbitmq] Add PrometheusRule. (helm#20478) [stable/drupal] Release 6.2.4 updating components versions (helm#20491) [stable/metabase] interpolate liveness and readiness probes (helm#20475) [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490) [stable/gocd] Quote ingress host (helm#20477) [stable/metabase] allow setting jetty options (helm#20456) [stable/pgadmin] upgrade to 4.17 and more (helm#20211) [stable/prometheus-operator] add apiserverConfig (helm#20453) [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464) Add annotation support to pushgateway service (helm#20351) Upgrade nfs-provisioner to v2.3.0 (helm#20468) [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471) [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467) [stable/redis] Add PrometheusRule. (helm#20388) ...
alexppg
pushed a commit
to alexppg/charts
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Glen Takahashi <glen@glentaka.com>
MarcusSorealheis
added a commit
to MarcusSorealheis/charts
that referenced
this pull request
Feb 4, 2020
…ts into solr_plugin_volume * 'solr_plugin_volume' of github.com:MarcusSorealheis/charts: (611 commits) bump version to be compatible with plugins. bump version to be compatible with plugins. [stable/kube-state-metrics] Version bump to 1.9.4 (helm#20543) [stable/nginx-ingress] allow clusterIP values to be set empty (helm#20518) update grafana sidecar to 0.1.75 (helm#20538) [stable/mongodb] Release 7.8.2 updating components versions (helm#20537) [stable/testlink] add service annotations (helm#20531) Rr/strategy (helm#20533) [stable/superset] Update Maintainers List (helm#20493) [stable/nfs-server-provisioner] New nfs-provisioner with NFSv3 support (helm#19260) [stable/pgadmin] removed abundance curly bracket (helm#20530) Seq: use deployment strategy (helm#20526) [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523) [stable/prometheus-redis-exporter] Update image for exporter (helm#19317) update alantis version (helm#20507) [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517) [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409) Allow DNS egress to resolve hostnames (helm#20437) [stable/rabbitmq] Add PrometheusRule. (helm#20478) [stable/drupal] Release 6.2.4 updating components versions (helm#20491) ...
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
Signed-off-by: Glen Takahashi <glen@glentaka.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using networkPolicy.enabled: true, the slaves cannot connect to the master node because they use hostname lookup. Without an egress policy for DNS the slaves cannot resolve the ip of the master node.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])