Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/testlink] add service annotations #20531

Merged
merged 4 commits into from
Feb 4, 2020
Merged

[stable/testlink] add service annotations #20531

merged 4 commits into from
Feb 4, 2020

Conversation

dani8art
Copy link
Contributor

@dani8art dani8art commented Feb 4, 2020

Signed-off-by: darteaga darteaga@bitnami.com

What this PR does / why we need it:

This PR adds the possibility of passing annotations to the service so that we can configure better the service, e.g: internal load balancers.

Which issue this PR fixes

Special notes for your reviewer:

N/A

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@dani8art
add service annotations
19eb26b 
Signed-off-by: darteaga <darteaga@bitnami.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 4, 2020
@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @dani8art. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

juan131
juan131 suggested changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please check my suggestions

stable/testlink/templates/svc.yaml Outdated Show resolved Hide resolved
stable/testlink/values.yaml Show resolved Hide resolved
@dani8art
PR commented changes
b1609bc 
Signed-off-by: darteaga <darteaga@bitnami.com>
@dani8art
fix lint errors
f35f365 
Signed-off-by: darteaga <darteaga@bitnami.com>
juan131
juan131 reviewed Feb 4, 2020
View reviewed changes
stable/testlink/Chart.yaml Outdated Show resolved Hide resolved
@dani8art
bump minor version as suggested
42aa4d3 
Signed-off-by: darteaga <darteaga@bitnami.com>
juan131
juan131 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the suggestions!

@juan131
Copy link
Collaborator

juan131 commented Feb 4, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dani8art, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@dani8art
Copy link
Contributor Author

dani8art commented Feb 4, 2020

Thanks for implementing the suggestions!

Thank you for suggesting and reviewing ;)

@k8s-ci-robot k8s-ci-robot merged commit 57aebcc into helm:master Feb 4, 2020
@dani8art dani8art deleted the add-annotations-to-testlink-service branch February 4, 2020 11:24
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge branch 'solr_plugin_volume' of github.com:MarcusSorealheis/char…
b4833a0 
…ts into solr_plugin_volume

* 'solr_plugin_volume' of github.com:MarcusSorealheis/charts: (611 commits)
  bump version to be compatible with plugins.
  bump version to be compatible with plugins.
  [stable/kube-state-metrics] Version bump to 1.9.4 (helm#20543)
  [stable/nginx-ingress] allow clusterIP values to be set empty (helm#20518)
  update grafana sidecar to 0.1.75 (helm#20538)
  [stable/mongodb] Release 7.8.2 updating components versions (helm#20537)
  [stable/testlink] add service annotations (helm#20531)
  Rr/strategy (helm#20533)
  [stable/superset] Update Maintainers List (helm#20493)
  [stable/nfs-server-provisioner] New nfs-provisioner with NFSv3 support (helm#19260)
  [stable/pgadmin] removed abundance curly bracket (helm#20530)
  Seq: use deployment strategy (helm#20526)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  ...
@carrodher carrodher mentioned this pull request Feb 20, 2020
Closed
@elliottucker
Copy link

hi @carrodher
Is it possible to have different service annotations for the two services that get created? rabbitmq-ha (Type: LoadBalancer) and rabbitmq-ha-discovery (Type:ClusterIP) ?

The issue I'm having is that I'd like to use external-dns controller but that's finding the annotation for both services and flip flops between both setting the DNS entries. If we could have different service annotations for each service I'd be able to include what I need in just the one service. (Type:LoadBalancer in my case)

Thanks!

@juan131
Copy link
Collaborator

juan131 commented Jul 20, 2020

Given the stable deprecation timeline, this Bitnami maintained Helm chart is now located at bitnami/charts. Please visit the bitnami/charts GitHub repository to create Issues or PRs.

In this issue we tried to explain more carefully the reasons and motivations behind this transition, please don't hesitate to add a comment in this issue if you have any question related to the migration itself.

mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@dani8art
[stable/testlink] add service annotations (helm#20531)
fdf0172 
* add service annotations

Signed-off-by: darteaga <darteaga@bitnami.com>

* PR commented changes

Signed-off-by: darteaga <darteaga@bitnami.com>

* fix lint errors

Signed-off-by: darteaga <darteaga@bitnami.com>

* bump minor version as suggested

Signed-off-by: darteaga <darteaga@bitnami.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juan131 juan131 juan131 approved these changes

@miguelaeh miguelaeh Awaiting requested review from miguelaeh

@prydonius prydonius Awaiting requested review from prydonius

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/testlink]how to add service annotation to create a internal load balancer
5 participants
@dani8art @k8s-ci-robot @juan131 @elliottucker @helm-bot