-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/external-dns] Add the ability for external-dns to manage records with Istio Virtual… #22669
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thomasv314 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @thomasv314. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Thomas Vendetta <tom.vendetta@syapse.com>
This should be good to go now that istio virtualservices are supported in external-dns kubernetes-sigs/external-dns#1607 /assign @juan131 |
@thomasv314 @juan131 will this feature be merged soon? We are running istio and knative workloads in our cluster with external-dns configured and this would solve a lot of our problems |
Given the In this issue we tried to explain more carefully the reasons and motivations behind this transition, please don't hesitate to add a comment in this issue if you have any question related to the migration itself. |
@juan131 I appreciate you taking the time to clarify, thanks! @Karthik-13 this is merged into bitnami/charts: bitnami/charts#3216 |
@thomasv314 @juan131 The helm chart has the support for virtualservice added. But the image mentioned in values.yaml doesn't have the feature and is causing the pod to fail. Could you please specify which version of bitnami/external-dns image to use? |
@Karthik-13 Yep, IMO that's not this charts responsibility. I built off master and pushed to our private registry, the functionality should be available in the next tagged release of external-dns. |
Add the ability for external-dns to manage records with Istio Virtual Service resources
Required when either of these PR's is merged:
kubernetes-sigs/external-dns#1358
kubernetes-sigs/external-dns#1607
Is this a new chart
What this PR does / why we need it:
This PR gives external-dns the ability to inspect VirtualService resources and delegate domain records to them.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)