-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/grafana] add useExistingRole option #23370
Conversation
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
Signed-off-by: Klavs Klavsen <klavs@EnableIT.dk>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KlavsKlavsen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @KlavsKlavsen. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/test pull-charts-e2e |
I see no reason for the pull-charts-e2e failure ? |
/test pull-charts-e2e |
Test says return code != 200.. But nothing what it actually got - and the grafana pod logs looks perfect - last entry says is listening as it should.. Seems more like perhaps a matter of timing - test pod starting too quickly or something? |
/test pull-charts-e2e |
@KlavsKlavsen: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This chart is deprecated: #23662 |
What this PR does / why we need it:
This add useExistingRole option, which enables chart to skip role creation and instead bind to existing role - which is needed in f.ex. some RHEL openshift+jenkins setups, where "normal users" are not allowed to create role's (but can do the rolebinding and sa creation to the existing role).
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)