-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
Signed-off-by: zanhsieh <zanhsieh@gmail.com>
@zanhsieh You need to add |
@zanhsieh May I also make a few suggestions about the new repo?
|
/lgtm |
/retest |
Signed-off-by: David Karlsen <david@davidkarlsen.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zanhsieh out of curiosity, why is the repo called helm2? Is there one for helm3? |
@mrueg |
You could simplify your life if you would call the repository helm-charts and put both charts in a subfolder named |
Hm, @zanhsieh re #23662 (comment) I don't believe this should have been merged yet. As far as I can tell, the chart at https://github.com/grafana/helm2-grafana is not installable for end users (or if it is, the Readme still instructs users to install |
@zanhsieh I could help with the migration. If you want I can prepare a repo including the history, add you as admin and you could transfer it to https://github.com/grafana/. Just let me know if you want that help. |
I very much second what @scottrigby and @torstenwalter say. Bring it over including the history. Also, the chart must in a subfolder named after the chart. |
Also, it's probably not a good idea to have separate charts for Helm 2 and 3. That would be two codebases for the same thing with the risk that things diverge. I'd stick with Helm 2 for now which is also installable with Helm 3 until Helm 2 reaches EOL which is pretty soon anyways. You can then update the chart for Helm 3 and drop Helm 2 compatibility. |
@torstenwalter @unguiculus |
I see there are a bunch of charts in the loki repo - https://github.com/grafana/loki/tree/master/production/helm maybe it would make sense for the grafana folks to create https://github.com/grafana/helm-charts and consolidate them all into one place ? |
Accepted the invite. Which charts should be migrated there? Just grafana or also loki? If you list them here then we can migrate them in one go (will be easier). |
@torstenwalter @paulczar |
@torstenwalter fun idea. you could also bring in loki, and start up the convo with the loki maintainers to see if they'd like to have all the ci/cd and maintenance in once place (if there's a concern about permissions, mention GitHub CODEOWNERS as the solution, as we did for prometheus-community). If they decide to keep it there, the work is done. If they prefer not to have all the grafana charts in the same repo, you would just need to filter it out, and everything else will stay the same. WDYT? |
Started the discussion in grafana/loki#2593 |
Short update: chart is now migrated including history to https://github.com/grafana/helm-charts and GitHub workflows are set up. Deprecation notice will be updated with #23686. |
This chart was moved to a new location: https://github.com/grafana/helm-charts
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)