Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Make extraVolumeMounts[].existingClaim optional #23647

Closed
wants to merge 2 commits into from

Conversation

catac
Copy link

@catac catac commented Aug 30, 2020

Make extraVolumeMounts[].existingClaim optional so that extraVolumeMounts can be used in conjunction with extraContainerVolumes. Also, provide an example in README.md on how to use both, in order to trust system certificates in the Grafana container.

Signed-off-by: Catalin Cirstoiu Catalin.Cirstoiu@gmail.com

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

…Mounts can be used in conjunction with extraContainerVolumes. Also, provides an example in README.md on how to use both, in order to trust system certificates in the Grafana container.

Signed-off-by: Catalin Cirstoiu <Catalin.Cirstoiu@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: catac
To complete the pull request process, please assign maorfr
You can assign the PR to them by writing /assign @maorfr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 30, 2020
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @catac. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2020
Signed-off-by: Catalin Cirstoiu <Catalin.Cirstoiu@gmail.com>
@davidkarlsen
Copy link
Member

This chart is deprecated: #23662
Please submit PRs against: https://github.com/grafana/helm2-grafana

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants