Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent charts of prometheus-operator? #30

Closed
sachinmsft opened this issue Aug 26, 2020 · 12 comments
Closed

Dependent charts of prometheus-operator? #30

sachinmsft opened this issue Aug 26, 2020 · 12 comments
Assignees
Labels
question Further information is requested

Comments

@sachinmsft
Copy link

I see that we are moving prometheus charts from stable to this repo. what about other charts that prometheus-operatror deploy like grafana, kube-state-metrics. ?

@sachinmsft
Copy link
Author

@scottrigby

@scottrigby
Copy link
Member

@sachinmsft This was asked in a long thread of collapsed comments on #14. Here was my reply: #1 (comment)

Do you have any other thoughts about this?

@scottrigby scottrigby added the question Further information is requested label Aug 27, 2020
@monotek
Copy link
Member

monotek commented Aug 28, 2020

I guess grafana will be moved to an official grafana helm repo anyway. Loki for example is already managed by the grafana guys. See: https://hub.helm.sh/charts/loki/loki

@scottrigby
Copy link
Member

Re grafana I thought I replied to them last week but can't find the issue. So just made this comment: grafana/grafana#18665 (comment)

@scottrigby
Copy link
Member

Also see helm/charts#23662

@scottrigby
Copy link
Member

Update: stable/grafana has officially deprecated and moved to a new repo 🙌 So we should update that dependency definition.

@gkarthiks
Copy link
Member

@scottrigby should we change the dependency after the rename of prom-operator?

@scottrigby
Copy link
Member

@gkarthiks yes as a fast follow of #1 if we can get that tested and reviewed one more time and merged soon. Otherwise I can update as part of that PR

@gkarthiks
Copy link
Member

@scottrigby No worries, I can update this soon after the #1 is done.

@gkarthiks gkarthiks self-assigned this Sep 6, 2020
@scottrigby
Copy link
Member

If you want you could make it sooner against the #1 PR branch instead of main

@gkarthiks
Copy link
Member

@scottrigby is there anything else we have to do against this issue here?

@scottrigby
Copy link
Member

I don't think so. We can follow up with kube-state-metrics here kubernetes/kube-state-metrics#1153 but until then, nothing is needed. Thanks!

nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue Dec 21, 2023
[prometheus-node-exporter] Integrate process-exporter and calico-exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants