Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve site on mobile #741

Open
jlosito opened this issue Jul 4, 2020 · 3 comments · May be fixed by #1535
Open

Improve site on mobile #741

jlosito opened this issue Jul 4, 2020 · 3 comments · May be fixed by #1535
Assignees
@flynnduism
Labels
design

Comments

@jlosito
Copy link

jlosito commented Jul 4, 2020

It’s difficult to select the hamburger menu icon in the upper right hand corner on mobile with the BLM banner in the way on the main page. Would it be possible to add a button to either hide the message or raise/overlay the hamburger menu icon so that the menu icon and the BLM messages are both displayed?

I’m trying to view on site on an iPhone 7.
@bacongobbler bacongobbler transferred this issue from helm/helm Jul 5, 2020
@flynnduism
Copy link
Member

Thanks for the issue @jlosito. Work to correct this is under way via #705

@flynnduism flynnduism self-assigned this Jul 7, 2020
@jeremygaither
Copy link

It is nearly impossible to make the current site scroll on Safari iOS 14.2 due to the hovering elements (top hamburger). It will scroll and bounce back to the prior position. Sometimes it will scroll if hitting the side of the page just right and then again in the center of the page.

@flynnduism flynnduism mentioned this issue Sep 9, 2021
Merged
@josegonzalez
Copy link

Just want to note that @jeremygaither's comment still applies (on a iOS 16.3.1 browsing on an iPhone 12 mini). I haven't had time to check what is causing it, but will see if I can connect a debugger to my phone and find out what is causing the bouncing/how to fix later this week :)

lightster added a commit to lightster/helm-www that referenced this issue Dec 9, 2023
@lightster
Fix web site scrolling on mobile browsers
7bd3411 
Scrolling pages on the Helm web site is difficult on mobile devices due
to nested scrolling containers. This changeset removes the nested
scrolling containers.

The fix to remove the nested scrolling containers caused pages to start
scrolling horizontally because the content of the pages have negative
margins, which makes the page wider than 100%. The rest of this
changeset addresses the negative margins by removing them and/or
offsetting them in each element that was causing the page to horizontal
scroll.

Fixes helm#741
Fixes helm#1393
Fixes helm#1464

Signed-off-by: Matt Light <matt@tinyprint.dev>
@lightster lightster linked a pull request Dec 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flynnduism flynnduism

Labels
design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix web site scrolling on mobile browsers lightster/helm-www
5 participants
@josegonzalez @flynnduism @bridgetkromhout @jeremygaither @jlosito