[WIP] [#683] revamp device layouts #705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>
Signed-off-by: Matthew Fox <matt@getbalto.com>
Signed-off-by: jmnote <opcore@gmail.com>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
This includes documentation of most of the template functions available within Helm templates. Signed-off-by: Matt Farina <matt@mattfarina.com>
There is a difference between building a preview/serging localling and deploying to production. Building a preview uses make build-preview which has different options from the make build used for produciton. Something in the hugo options ended up changing the handling of URLs. The preview step works the same as `hugo serve` making it difficult to notice in dev. The issue here was that external URLs were passed through the relLangURL template function. This is only to be used for relative URLs. In some modes it was passing through the full URL and in others it was taking the path, internationalizing it, and passing that along. When it mangled the full URL we had the issue. Since these URLs are for full URLs where we want the full thing passed through, this change removes the use of relLangURL for absolute URLs. Signed-off-by: Matt Farina <matt@mattfarina.com>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: jmnote <opcore@gmail.com>
Signed-off-by: Jeffrey Chu <peihuachu1112@gmail.com>
Signed-off-by: Jeffrey Chu <peihuachu1112@gmail.com>
Signed-off-by: Bryan Dady <bryan@subsplash.com>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Jeffrey Chu <peihuachu1112@gmail.com>
Signed-off-by: Jeffrey Chu <peihuachu1112@gmail.com>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Paul "Hampy" Hampson <p_hampson@wargaming.net>
…Templates' best practices Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Matthew Fox <matt@getbalto.com>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Wyn Van Devanter <wynvandev@gmail.com>
Signed-off-by: Wyn Van Devanter <wynvandev@gmail.com>
Signed-off-by: Wyn Van Devanter <wynvandev@gmail.com>
Translations should not have aliases. When that happens they override the english language aliases. Closes helm#773 Signed-off-by: Matt Farina <matt@mattfarina.com>
Signed-off-by: zbrookle <zachb1996@yahoo.com>
Signed-off-by: Wyn Van Devanter <wynvandev@gmail.com>
…levant `helm install ...` requires that a value is passed for chart instance name, else `--generate-name` option should be applied. Signed-off-by: Igwe Kalu <igwe.kalu@live.com>
Signed-off-by: flynnduism <dev@ronan.design>
|
Closing this old PR, replacing it with #1194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to improve the layouts for mobile/tablet/small desktop displays.
Signed-off-by: flynnduism dev@ronan.design