Skip to content

Commit

Permalink
fix: change to newly recommended tool instead of pep517.build
Browse files Browse the repository at this point in the history
This was intended as a proof of concept; build seems to be the correct replacement.

See pypa/pyproject-hooks#83
  • Loading branch information
henryiii committed Sep 14, 2020
1 parent b515010 commit 9ecec74
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,14 @@ source, it is best to have Pip 10 on a manylinux1, macOS, or Windows system.
You can then build the SDists, or run any procedure that makes SDists
internally, like making wheels or installing. Since Pip itself
does not have an `sdist` command (it does have `wheel` and `install`), you will
need to use the `pep517` package directly:
need to use the upcoming `build` package:

```bash
# Normal package
python3 -m pep517.build -s .
python3 -m build -s .

# Global extra
PYBIND11_GLOBAL_SDIST=1 python3 -m pep517.build -s .
PYBIND11_GLOBAL_SDIST=1 python3 -m build -s .
```

If you want to use the classic "direct" usage of `python setup.py`, you will
Expand All @@ -232,7 +232,7 @@ When you invoke any `setup.py` command from the source directory, including
`pip wheel .` and `pip install .`, you will activate a full source build. This
is made of the following steps:

1. If the tool is PEP 518 compliant, like `pep517.build` or Pip 10+, it will
1. If the tool is PEP 518 compliant, like `build` or Pip 10+, it will
create a temporary virtual environment and install the build requirements
(mostly CMake) into it. (if you are not on Windows, macOS, or a manylinux
compliant system, you can disable this with `--no-build-isolation` as long
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/configure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,15 @@ jobs:
python-version: 3.8

- name: Prepare env
run: python -m pip install -r tests/requirements.txt pep517 twine --prefer-binary
run: python -m pip install -r tests/requirements.txt build twine --prefer-binary

- name: Python Packaging tests
run: pytest tests/extra_python_package/

- name: Build SDist and wheels
run: |
python -m pep517.build -s -b .
PYBIND11_GLOBAL_SDIST=1 python -m pep517.build -s -b .
python -m build -s -w .
PYBIND11_GLOBAL_SDIST=1 python -m build -s -w .
- name: Check metadata
run: twine check dist/*
Expand Down

0 comments on commit 9ecec74

Please sign in to comment.