Pull out high-level interfaces as an extended example #83

takluyver · 2020-06-14T21:37:01Z

An attempt to tackle #82, by putting all the code that tries to manage environments & installation into a separate buildtool_demo package, which does not get installed.

This will break things for anyone who was relying on the high-level functionality being in pep517, but I don't see any way to clean it up without doing that.

The functions for loading & checking the build-system info are retained as part of the real package, in pep517.pyproject.

pradyunsg · 2020-07-05T01:47:20Z

Suggestion: move it into examples/*, to clearly denote that it's an example and make room for us to add additional things/examples/demos if we want to in the future.

takluyver · 2020-07-13T20:34:17Z

OK, I've moved it into an examples/ folder; I agree that's neater. After some fiddling with CI, the tests embedded in that example are working again.

pradyunsg

Looks great to me! ^.^

takluyver · 2020-09-03T13:57:28Z

Thanks @pradyunsg :-)

pradyunsg · 2020-09-03T14:05:04Z

How do we plan to manage the rollout of this change? There's probably a fair number of folks using this as a CLI tool.

FFY00 · 2020-09-03T14:46:52Z

I'd probably wait until a new python-build release/python-build gets into PyPA, so that we can recommend that as an alternative.

pradyunsg · 2020-09-05T07:12:31Z

@FFY00 any ETA on that? anything to help with that?

FFY00 · 2020-09-05T17:14:15Z

I need to fix some simple issues and probably improve the test suite a bit. I don't think it should take too long.

pganssle · 2020-09-08T19:44:51Z

Am I correct in understanding that this removes pep517.build? Was there ever a deprecation warning on this?

I guess I should have taken more seriously the warnings that it wasn't necessarily ready for production use, but given that this was the only PEP 517 build front-end for several years, I would kind of expect it to keep working at least for a while. I'll now have to run around and pin the versions on a bunch of my projects now.

If the justification is "we'll get a release of python-build soon, and we'll release this after that", that... doesn't seem like a long enough overlap.

The high level CLI will evidently be removed soon (and suddenly): pypa/pyproject-hooks#83

pep517 will apparently soon drop the pep517.build CLI, suddenly. No replacement is available, so we will pin to the latest version that supports it. pypa/pyproject-hooks#83

pep517.build is deprecated see: pypa/pyproject-hooks#83

see: pypa/pyproject-hooks#83

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83 * Remove check stage as done implicitly with python-build - c.f. https://github.com/FFY00/python-build/issues/105

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

@YannickJadoul

* feat: setup.py redesign and helpers * refactor: simpler design with two outputs * refactor: helper file update and Windows support * fix: review points from @YannickJadoul * refactor: fixes to naming and more docs * feat: more customization points * feat: add entry point pybind11-config * refactor: Try Extension-focused method * refactor: rename alt/inplace to global * fix: allow usage with git modules, better docs * feat: global as an extra (@YannickJadoul's suggestion) * feat: single version location * fix: remove the requirement that setuptools must be imported first * fix: some review points from @wjacob * fix: use .in, add procedure to docs * refactor: avoid monkeypatch copy * docs: minor typos corrected * fix: minor points from @YannickJadoul * fix: typo on Windows C++ mode * fix: MSVC 15 update 3+ have c++14 flag See <https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version?view=vs-2019> * docs: discuss making SDists by hand * ci: use pep517.build instead of manual setup.py * refactor: more comments from @YannickJadoul * docs: updates from @ktbarrett * fix: change to newly recommended tool instead of pep517.build This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83 * docs: updates from @wjakob * refactor: dual version locations * docs: typo spotted by @wjakob

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83 * Remove check stage as done implicitly with python-build

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83

pep517.build is going to be deprecated: pypa/pyproject-hooks#83 So let's use a tool that explicitly has an interface we can use to build.

This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91

Pull out high-level interfaces as an extended example

3492e4a

takluyver mentioned this pull request Jun 15, 2020

main: build in a virtual env by default pypa/build#18

Merged

takluyver added 9 commits July 13, 2020 21:05

Move buildtool into examples folder

92da387

Fix import

6b8b311

Add README in examples folder

87bb9d3

Tests need package installed now

7e2e144

Expand flit_core requirement to <4

00072e8

Enable isolated_build for Tox to use PEP 517

021ed35

Try upgrading virtualenv on Travis

94c4a87

Or maybe upgrade pip

512ddb4

Try using virtualenv for tox environments

e70e03e

pradyunsg mentioned this pull request Aug 30, 2020

Unset PIP_REQUIRE_VIRTUALENV when running 'pip' #84

Closed

pradyunsg reviewed Aug 30, 2020

View reviewed changes

pradyunsg approved these changes Aug 30, 2020

View reviewed changes

takluyver merged commit b5d5c20 into master Sep 3, 2020

takluyver deleted the separate-highlevel branch September 3, 2020 13:57

pradyunsg mentioned this pull request Sep 3, 2020

Restructure this library to better separate low-level and high-level features #82

Closed

pradyunsg mentioned this pull request Sep 8, 2020

virtualenv with --system-site-packages breaks pip's build isolation pypa/pip#6264

Closed

pganssle added a commit to pganssle/zoneinfo that referenced this pull request Sep 8, 2020

Pin pep517 library

4e9183e

The high level CLI will evidently be removed soon (and suddenly): pypa/pyproject-hooks#83

pganssle mentioned this pull request Sep 8, 2020

Pin pep517 library pganssle/zoneinfo#91

Closed

pganssle added a commit to python/tzdata that referenced this pull request Sep 8, 2020

Pin pep517 to 0.8.2

10fabed

pep517 will apparently soon drop the pep517.build CLI, suddenly. No replacement is available, so we will pin to the latest version that supports it. pypa/pyproject-hooks#83

pganssle mentioned this pull request Sep 8, 2020

Pin pep517 to 0.8.2 python/tzdata#27

Closed

blink1073 mentioned this pull request Sep 11, 2020

pep517.build is deprecated ipython/traitlets#622

Closed

rmorshea added a commit to ipython/traitlets that referenced this pull request Sep 12, 2020

closes: #622

b0d3679

pep517.build is deprecated see: pypa/pyproject-hooks#83

rmorshea mentioned this pull request Sep 12, 2020

closes: #622 ipython/traitlets#623

Merged

rmorshea added a commit to reactive-python/reactpy that referenced this pull request Sep 12, 2020

use python-build

b09cda6

see: pypa/pyproject-hooks#83

rmorshea mentioned this pull request Sep 12, 2020

use python-build reactive-python/reactpy#217

Merged

rmorshea added a commit to reactive-python/reactpy that referenced this pull request Sep 12, 2020

use python-build

de78263

see: pypa/pyproject-hooks#83

matthewfeickert mentioned this pull request Sep 14, 2020

Migrate from pep517 to using build in tests and workflows scikit-hep/pyhf#1065

Closed

henryiii added a commit to henryiii/pybind11 that referenced this pull request Sep 14, 2020

fix: change to newly recommended tool instead of pep517.build

641c758

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

henryiii added a commit to henryiii/pybind11 that referenced this pull request Sep 14, 2020

fix: change to newly recommended tool instead of pep517.build

9ecec74

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

henryiii added a commit to henryiii/pybind11 that referenced this pull request Sep 15, 2020

fix: change to newly recommended tool instead of pep517.build

496f843

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

henryiii added a commit to henryiii/pybind11 that referenced this pull request Sep 15, 2020

fix: change to newly recommended tool instead of pep517.build

e541907

This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83

matthewfeickert added a commit to scikit-hep/pylhe that referenced this pull request Sep 22, 2020

chore: Migrate from pep517 to python-build (#38)

82ecaba

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83

astrojuanlu mentioned this pull request Sep 23, 2020

MNT: Update doc about setup.py and py.test astropy/astropy#10756

Merged

abn mentioned this pull request Sep 26, 2020

Pull in pep517 high-level interfaces into poetry codebase python-poetry/poetry#2983

Closed

thiagokokada added a commit to thiagokokada/i3pyblocks that referenced this pull request Sep 27, 2020

Switch to python-build instead of pep517

c545ad3

pep517.build is going to be deprecated: pypa/pyproject-hooks#83 So let's use a tool that explicitly has an interface we can use to build.

thiagokokada mentioned this pull request Sep 27, 2020

Switch to python-build instead of pep517 thiagokokada/i3pyblocks#116

Merged

pradyunsg mentioned this pull request Oct 6, 2020

Revert "Pull out high-level interfaces as an extended example" #96

Merged

dmtucker mentioned this pull request Oct 11, 2020

Build Changes dmtucker/backlog#80

Closed

ahesford mentioned this pull request Mar 15, 2021

New package: python3-pep517-0.9.1 void-linux/void-packages#28843

Closed

3 tasks

webknjaz mentioned this pull request Apr 13, 2021

Switch from pep517 lib to build CLI ansible/pylibssh#199

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull out high-level interfaces as an extended example #83

Pull out high-level interfaces as an extended example #83

takluyver commented Jun 14, 2020

pradyunsg commented Jul 5, 2020 •

edited

Loading

takluyver commented Jul 13, 2020

pradyunsg left a comment

takluyver commented Sep 3, 2020

pradyunsg commented Sep 3, 2020 •

edited

Loading

FFY00 commented Sep 3, 2020

pradyunsg commented Sep 5, 2020

FFY00 commented Sep 5, 2020

pganssle commented Sep 8, 2020

Pull out high-level interfaces as an extended example #83

Pull out high-level interfaces as an extended example #83

Conversation

takluyver commented Jun 14, 2020

pradyunsg commented Jul 5, 2020 • edited Loading

takluyver commented Jul 13, 2020

pradyunsg left a comment

Choose a reason for hiding this comment

takluyver commented Sep 3, 2020

pradyunsg commented Sep 3, 2020 • edited Loading

FFY00 commented Sep 3, 2020

pradyunsg commented Sep 5, 2020

FFY00 commented Sep 5, 2020

pganssle commented Sep 8, 2020

pradyunsg commented Jul 5, 2020 •

edited

Loading

pradyunsg commented Sep 3, 2020 •

edited

Loading