Unset PIP_REQUIRE_VIRTUALENV when running 'pip' #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PIP_REQUIRE_VIRTUALENV environment variable is set, it blocks `pip install` from running without a virtualenv being activated. This broke using `python -m pep517.build` on my project:
```
$ python -m pep517.build .
ERROR: Could not find an activated virtualenv (required).
Traceback (most recent call last):
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/site-packages/pep517/build.py", line 124, in <module>
main(parser.parse_args())
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/site-packages/pep517/build.py", line 120, in main
build(args.source_dir, dist, args.out_dir)
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/site-packages/pep517/build.py", line 87, in build
env.pip_install(system['requires'])
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/site-packages/pep517/envbuild.py", line 100, in pip_install
check_call(
File "/Users/chainz/.pyenv/versions/3.8.3/lib/python3.8/subprocess.py", line 364, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/Users/chainz/.pyenv/versions/3.8.3/bin/python', '-m', 'pip', 'install', '--ignore-installed', '--prefix', '/var/folders/kq/02p9h16n7zv_z7bhzmg6y_pm0000gn/T/pep517-build-env-fkh9ckg8', 'setuptools >= 40.6.0', 'wheel']' returned non-zero exit status 3.
```
This change makes pep517 unset the environment variable since its installs are safe to run.
|
Closing since we're going a different direction with this project (see #83). You might be interested in https://github.com/FFY00/python-build/issues/42 -- which will become pypa/build at some point in the future. |
|
Thanks for the reference. I'll keep an eye out for an official python-build release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PIP_REQUIRE_VIRTUALENV environment variable is set, it blocks
pip installfrom running without a virtualenv being activated. This broke usingpython -m pep517.buildon my project:This change makes pep517 unset the environment variable since its installs are safe to run.