-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset PIP_REQUIRE_VIRTUALENV when running 'pip' #90
Comments
adamchainz
added a commit
to adamchainz/python-build
that referenced
this issue
Sep 9, 2020
Fixes pypa#90. [The `--isolated` option](https://github.com/pypa/pip/blob/89a51a6fefec826256fb334ea6244dfb0b3455a0/src/pip/_internal/cli/cmdoptions.py#L153) ignores environment variables and user configuration, so only the passed command will be run. This fixes `python -m build` for users with `PIP_REQUIRE_VIRTUALENV`, and maybe some other cases. I'm not sure if it will break other flows though, such as if a proxy is configured.
adamchainz
added a commit
to adamchainz/python-build
that referenced
this issue
Sep 10, 2020
adamchainz
added a commit
to adamchainz/python-build
that referenced
this issue
Sep 10, 2020
adamchainz
added a commit
to adamchainz/python-build
that referenced
this issue
Sep 10, 2020
FFY00
pushed a commit
that referenced
this issue
Sep 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is the same issue as in pep517: pypa/pyproject-hooks#84
If
PIP_REQUIRE_VIRTUALENV
is set (to a non-empty value) when runningpython -m build
,pip
errors with its "ERROR: Could not find an activated virtualenv (required)." message:The solution is to unset the environment variable for the subprocess.
The text was updated successfully, but these errors were encountered: