Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipenv version #727

Closed
wants to merge 1 commit into from
Closed

Conversation

harrywhite4
Copy link

@harrywhite4 harrywhite4 commented Jul 6, 2018

An issue with pipenv's --system --deploy options has been fixed in a newer release as described here
https://github.com/pypa/pipenv/blob/master/HISTORY.txt#L95

This was likely the casue of #704 and #702 so it would be nice to switch to the latest version

@sigmavirus24
Copy link
Contributor

Yes, and looking through the issues opened since 2018.6.25 and 2018.7.1 there are significant issues with packages using {git = ...} and some other issues. Unfortunately no matter what version of pipenv we pick, it will be problematic for a good portion of users.

See also:

@harrywhite4
Copy link
Author

I understand it's difficult to find a version that everyone will be happy with. Being able to set an environment variable to override the version might be a better solution

@sigmavirus24
Copy link
Contributor

Perhaps an OVERRIDDEN_PIPENV_VERSION that overrides our default?

sigmavirus24 added a commit that referenced this pull request Jul 10, 2018
This also starts tracking which Pipenv version users are selecting to
use.

Closes #702
Closes #704
Closes #706
Closes #727
@techalchemy
Copy link

@sigmavirus24 if you file issues with us or you let me know directly about things that impact your pipeline I can triage these more effectively -- my company has an enterprise account with heroku and these do have an impact on me too so I'm happy to help

@sigmavirus24
Copy link
Contributor

@techalchemy I referenced exactly the issues that would be blockers above. It sounds like you're expecting something else though, what do you think I should have done differently?

jxltom added a commit to jxltom/heroku-buildpack-python that referenced this pull request Sep 28, 2018
@harrywhite4
Copy link
Author

Closing in favor of #732

@harrywhite4 harrywhite4 closed this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants