Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index_indicators check needs improvement. #2494

Closed
jpaulodit opened this issue Jul 3, 2018 · 2 comments · Fixed by #2814
Closed

index_indicators check needs improvement. #2494

jpaulodit opened this issue Jul 3, 2018 · 2 comments · Fixed by #2814
Labels
Type: Bug 🐛 This issue is a bug.

Comments

@jpaulodit
Copy link

jpaulodit commented Jul 3, 2018

Issue description

When installing local package, the logical check on this line does not work correctly when package name has -i in it.

if any(s in line for s in index_indicators):

Actual result

Pipenv tries installing a package called -e

Steps to replicate

Suppose you have a local python package named like marathon-python-internal

pipenv install -e ../packages/marathon-python-lnternal/

This results in the code flow falling inside the IF condition vs some other package name that doesn't have the string -i in them eg

pipenv install -e ../packages/funniest/

pipenv, version 2018.7.1
@techalchemy
Copy link
Member

hmmm yes, that is a problem.

@mlouielu
Copy link
Contributor

Some points I want to know:

  1. pipenv install -i https://foo.bar

In pipenv, it will include source in Pipfile and https://foo.bar

  1. pipenv install -i https://foo -i https://bar

It will only include source in Pipfile and https://bar

  1. pipenv install -i https://foo --extra-index-url https://bar

It should include source in Pipfile, and https://foo, and https://bar

Is that right @techalchemy ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants