Fix index_indicators condition

[mlouielu]

This will not match:

pipenv install -e packages/haha-internal

Fix #2494

[techalchemy]

Hey there, thanks for the PR! I believe the direction we want to go on this is to handle parsing index groups with click if possible, as this logic is kind of messy as is. I’m ok with you taking a crack at it if you like.

I could be persuaded to merge a temporary fix in the meantime, but I believe it would have to handle parsing everywhere we are currently doing it with this approach.

[mlouielu]

@techalchemy yeah, sure. But previous time #2299 to make --editable a click option end with closed PR, not sure if it is worth to make it an option or not.

[uranusjr]

@mlouielu Just do it (the editable option too, I think they are good if done correctly).

[techalchemy]

The editable one didn’t capture the change needed all the way through the codebase as I recall and it would have just broken a lot of things. I’d love to have these as click options, but I want to re-affirm that doing so involves more than just altering the cli. The logic of both of these flows through the entire application and needs to be traced and modified to accommodate those changes.

[mlouielu]

@techalchemy @uranusjr OK, I'll open a new PR for this!

[techalchemy]

closing for now, I have a fix for this-- thanks for the work you put in on it!

[mlouielu]

@techalchemy can you point me which commit/PR fix this? Thanks!

[techalchemy]

#2814