Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer image (or other naming) instead of docker for storing where images are published #45

Closed
colincasey opened this issue Jun 28, 2023 · 2 comments · Fixed by #88
Closed

Prefer image (or other naming) instead of docker for storing where images are published #45

colincasey opened this issue Jun 28, 2023 · 2 comments · Fixed by #88
Assignees
@colincasey
Labels
enhancement New feature or request

Comments

@colincasey
Copy link
Contributor

colincasey commented Jun 28, 2023 •
edited by edmorley
Loading

Noted by @joshwlewis in https://github.com/heroku/buildpacks-go/pull/106/files#r1245496285. The metadata key for where images are published to is stored under [metadata.release.docker] and brand-agnostic naming may be a better choice.

The artifact we're pointing at is an OCI image. image, registry, url, repository are all better IMO.

GUS-W-13738734.
@colincasey colincasey mentioned this issue Jun 28, 2023
Merged
@edmorley edmorley mentioned this issue Jun 29, 2023
Merged
@edmorley edmorley mentioned this issue Jul 11, 2023
Merged
@colincasey
Copy link
Contributor Author

if there are no objections i'm going to deprecate [metadata.release.docker] and add support for [metadata.release.image]

@edmorley
Copy link
Member

Sounds great, thank you!

@colincasey colincasey mentioned this issue Jul 25, 2023
Merged
@edmorley edmorley added the enhancement New feature or request label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colincasey colincasey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use [metadata.release.image] for repository key heroku/languages-github-actions
2 participants
@colincasey @edmorley