Use [metadata.release.image] for repository key #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backwards-compatible fix to allow for our buildpacks to migrate away from `[metadata.release.docker]` to define our `repository` location in favor of the more agnostic `[metadata.release.image]`.
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Aug 1, 2023
colincasey
added a commit
to heroku/buildpacks-jvm
that referenced
this pull request
Aug 1, 2023
colincasey
added a commit
to heroku/buildpacks-ruby
that referenced
this pull request
Aug 1, 2023
colincasey
added a commit
to heroku/buildpacks-php
that referenced
this pull request
Aug 1, 2023
colincasey
added a commit
to heroku/buildpacks-go
that referenced
this pull request
Aug 1, 2023
joshwlewis
pushed a commit
to heroku/buildpacks-go
that referenced
this pull request
Aug 1, 2023
edmorley
pushed a commit
to heroku/buildpacks-php
that referenced
this pull request
Aug 2, 2023
edmorley
pushed a commit
to heroku/buildpacks-ruby
that referenced
this pull request
Aug 2, 2023
edmorley
pushed a commit
to heroku/buildpacks-jvm
that referenced
this pull request
Aug 2, 2023
edmorley
pushed a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Aug 2, 2023
colincasey
added a commit
that referenced
this pull request
Aug 3, 2023
We can remove this fallback key for reading the repository to publish to now that the following PRs have been merged: - heroku/buildpacks-go#124 - heroku/buildpacks-php#15 - heroku/buildpacks-ruby#184 - heroku/buildpacks-jvm#555 - heroku/buildpacks-nodejs#610 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156
colincasey
added a commit
that referenced
this pull request
Aug 3, 2023
We can remove this fallback key for reading the repository to publish to now that the following PRs have been merged: - heroku/buildpacks-go#124 - heroku/buildpacks-php#15 - heroku/buildpacks-ruby#184 - heroku/buildpacks-jvm#555 - heroku/buildpacks-nodejs#610 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156
colincasey
added a commit
that referenced
this pull request
Aug 4, 2023
This was referenced Oct 24, 2023
edmorley
added a commit
that referenced
this pull request
Oct 24, 2023
As of #88 the metadata is now under `image.repository` not `docker.repository`, however, the error message still referenced the old location. This caused confusion in when debugging heroku/buildpacks-jvm#60: https://github.com/heroku/buildpacks-jvm/actions/runs/6626786735/job/18000413851#step:10:10 In addition to fixing the error message, I've renamed the enum variants and variables to match the new name. Lastly, I've updated the README to match the more concise release metadata style now used by all of our buildpacks (the repository URL is also a real example, to make it clearer that the URL shouldn't include the `docker://` prefix). Fixes #168. GUS-W-14355165.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards-compatible fix to allow for our buildpacks to migrate away from
[metadata.release.docker]to define ourrepositorylocation in favor of the more agnostic[metadata.release.image].Fixes #45, W-13738734