Improved buildpack assembly helpers #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess of building output directories is being improved in libcnb-package so that they are easier to work with in libcnb-package and libcnb-test.
Both the packaging and testing processes will use this new functionality to construct output locations to write compiled buildpacks into as well as rewriting dependency paths to resolved project-level dependencies declared with libcnb:{buildpack_id}.
In preparation for adding support for testing meta-buildpacks the process of building output directories is being improved in libcnb-package so that they are easier to work with in libcnb-package and libcnb-test.
Both the packaging and testing processes will use this new functionality to construct output locations to write compiled buildpacks into as well as rewriting dependency paths to resolved project-level dependencies declared with libcnb:{buildpack_id}.
In preparation for adding support for testing meta-buildpacks the process of assembling compiled buildpacks is being improved in `libcnb-package` so that they are easier to work with in `libcnb-package` and `libcnb-test`. Both the packaging and testing processes will use this new functionality to assemble compiled buildpacks into a target location.
In preparation for adding support for testing meta-buildpacks the process of assembling compiled buildpacks is being improved in `libcnb-package` so that they are easier to work with in `libcnb-package` and `libcnb-test`. Both the packaging and testing processes will use this new functionality to assemble compiled buildpacks into a target location.
colincasey
added
enhancement
|
This refactoring depends on related changes introduced in #632 |
…cator * main: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-cargo/src/package/error.rs # libcnb-cargo/tests/test.rs # libcnb-package/src/lib.rs
… libcnb-package/assembling_buildpack_directories * libcnb-package/buildpack_output_directory_locator: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-package/src/output.rs
… libcnb-package/assembling_buildpack_directories * libcnb-package/buildpack_output_directory_locator: addressing PR review comments
Malax
force-pushed
the
libcnb-package/buildpack_output_directory_locator
branch
2 times, most recently
from
58734d4
to
6e19132
Compare
Base automatically changed from
libcnb-package/buildpack_output_directory_locator
to
main
August 22, 2023 11:05
|
Closing in favour of #657 |
Merged
edmorley
deleted the
libcnb-package/assembling_buildpack_directories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding support for testing meta-buildpacks the process of assembling compiled buildpacks is being improved in
libcnb-packageso that they are easier to work with inlibcnb-packageandlibcnb-test.Both the packaging and testing processes will use this new functionality to assemble compiled buildpacks into a target location.