Move packaged buildpack directory out of target/
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/dist-directory
branch
2 times, most recently
from
6f36d7b
to
a01466d
Compare
Malax
commented
Jun 29, 2023
Malax
commented
Jun 29, 2023
Malax
force-pushed
the
malax/dist-directory
branch
from
a01466d
to
23ddfc9
Compare
Malax
force-pushed
the
malax/dist-directory
branch
from
23ddfc9
to
e1bf95b
Compare
Malax
force-pushed
the
malax/dist-directory
branch
from
e1bf95b
to
a704455
Compare
Malax
force-pushed
the
malax/dist-directory
branch
from
a704455
to
d446b51
Compare
|
@colincasey I understand. The thing is that we want to cut a release and get this breaking change in since the new release will have breaking changes already. If we postpone we have two releases with breaking changes. Happy to help out getting #632 back on track after this PR is merged - is that good enough for you? |
Malax
force-pushed
the
malax/dist-directory
branch
from
eaee752
to
b119578
Compare
edmorley
reviewed
Aug 17, 2023
Manuel was referring to breaking changes to the output directory of There is already one breaking change to that path (as of #580), which will mean needing the adjust the hardcoded paths in: If we release libcnb 0.14.0 without this PR, then once libcnb 0.15.0 is released, we'll have to update the hardcoded paths in languages-github-actions a second time. |
edmorley
reviewed
Aug 17, 2023
edmorley
reviewed
Aug 17, 2023
edmorley
reviewed
Aug 17, 2023
edmorley
changed the title
targettarget/
edmorley
approved these changes
Aug 18, 2023
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
* main: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
…cator * main: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-cargo/src/package/error.rs # libcnb-cargo/tests/test.rs # libcnb-package/src/lib.rs
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
… libcnb-package/assembling_buildpack_directories * libcnb-package/buildpack_output_directory_locator: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-package/src/output.rs
edmorley
added a commit
that referenced
this pull request
Aug 21, 2023
In #583 the function `get_buildpack_target_dir` was renamed to `get_buildpack_package_dir`. This renames the corresponding test to match.
colincasey
added a commit
that referenced
this pull request
Sep 13, 2023
Previously we could rely on knowing that packaged buildpacks would be written to a location within the `target` directory configured in Crate. This was easy to determine through program code and could be supplied to `find_buildpack_dirs` so that packaged buildpacks weren't accidentally included when searching for buildpacks. With the changes introduced in [#583](#583) it is no longer possible to easily determine the output location for packaged buildpacks. This PR adds the [ignore](https://crates.io/crates/ignore) crate to provide directory iteration that respects standard ignore files. This will give the user the ability to configure where we search within a project for buildpacks.
colincasey
added a commit
that referenced
this pull request
Sep 19, 2023
* Ignore file support when finding buildpacks Previously we could rely on knowing that packaged buildpacks would be written to a location within the `target` directory configured in Crate. This was easy to determine through program code and could be supplied to `find_buildpack_dirs` so that packaged buildpacks weren't accidentally included when searching for buildpacks. With the changes introduced in [#583](#583) it is no longer possible to easily determine the output location for packaged buildpacks. This PR adds the [ignore](https://crates.io/crates/ignore) crate to provide directory iteration that respects standard ignore files. This will give the user the ability to configure where we search within a project for buildpacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo libcnb packagecurrently puts the packaged buildpacks in Cargo'stargetdirectory. This requires a deep path to avoid clashing with Cargo itself. Modifiying thetargetdirectory might also interfere with other Rust tooling that doesn't expect non-Cargo files in that directory. One case is caching via https://github.com/Swatinem/rust-cache.This PR moves the packaged buildpacks into a dedicated directory. The default name and location for that directory is
$WORKSPACE_ROOT/libcnb-packaged. This can be changed via the new--package-diroption ofcargo libcnb package.See: #580 (comment)
Closes GUS-W-13813150