Skip to content
forked from v8/v8

Commit

Permalink
Manually roll build on 10.6 to include windows infra fix
Browse files Browse the repository at this point in the history
Roll /build:
https://chromium.googlesource.com/chromium/src/build/+log/339f8c6..6180903f

This includes https://crrev.com/c/3874828 which fixes flaky
compilation problems seen on the 10.6 V8 trybots:
https://ci.chromium.org/ui/p/v8/builders/try/v8_win_compile_dbg/b8800699999726054577/overview

This also rolls buildtools, libcxx and clang, since they have
dependencies with changes on /build.

This deps updates do not affect the Chrome release as it only updates
deps used to build V8 stand-alone, not V8 in Chrome.

This also also disables the extra-semi check which was enabled in the
same roll as otherwise a lot of source fixes need to be merged, too.

Bug: chromium:1337238
Change-Id: I92c74716fe36811761296e3bad1afe68e05beec8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3941885
Reviewed-by: Liviu Rau <liviurau@google.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#39}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
  • Loading branch information
mi-ac authored and V8 LUCI CQ committed Oct 11, 2022
1 parent dba3508 commit cd710a3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,9 @@ config("toolchain") {

# TODO(v8:12245): Fix shadowing instances and remove.
"-Wno-shadow",

# Disable this check on 10.6 to avoid merging multiple fixes.
"-Wno-extra-semi",
]

if (v8_current_cpu != "mips" && v8_current_cpu != "mipsel") {
Expand Down
12 changes: 6 additions & 6 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ deps = {
'base/trace_event/common':
Var('chromium_url') + '/chromium/src/base/trace_event/common.git' + '@' + '2ba7a48ca6167ee8ef311a7f3bc60b5e5cf5ee79',
'build':
Var('chromium_url') + '/chromium/src/build.git' + '@' + '339f8c652787781e6dd39ce0624c1a012f69ece8',
Var('chromium_url') + '/chromium/src/build.git' + '@' + '6180903f18b88b0263a59a547ab083c3baf1362d',
'buildtools':
Var('chromium_url') + '/chromium/src/buildtools.git' + '@' + '3d64821fbec0a8bc65c8f74167b777478903cbfb',
Var('chromium_url') + '/chromium/src/buildtools.git' + '@' + 'a7f5ad05c477e997b063b250eae6529ecc460a9f',
'buildtools/clang_format/script':
Var('chromium_url') + '/external/github.com/llvm/llvm-project/clang/tools/clang-format.git' + '@' + '8b525d2747f2584fc35d8c7e612e66f377858df7',
'buildtools/linux64': {
Expand All @@ -117,11 +117,11 @@ deps = {
'condition': 'host_os == "mac"',
},
'buildtools/third_party/libc++/trunk':
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libcxx.git' + '@' + '6cc58d640cfe272f079b07da2e03781796c6a6aa',
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libcxx.git' + '@' + '60f90783c34aeab2c49682c6d4ce5520c8cb56b3',
'buildtools/third_party/libc++abi/trunk':
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libcxxabi.git' + '@' + '039323b945911a54cb7400da8fb14fcbb0348e97',
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libcxxabi.git' + '@' + '5c3e02e92ae8bbc1bf1001bd9ef0d76e044ddb86',
'buildtools/third_party/libunwind/trunk':
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libunwind.git' + '@' + '030b4ebf32392cd0fa35d9971d78cbbbefa11f59',
Var('chromium_url') + '/external/github.com/llvm/llvm-project/libunwind.git' + '@' + '60a480ee1819266cf8054548454f99838583cd76',
'buildtools/win': {
'packages': [
{
Expand Down Expand Up @@ -288,7 +288,7 @@ deps = {
'third_party/zlib':
Var('chromium_url') + '/chromium/src/third_party/zlib.git'+ '@' + '8d1d3e341948009ed8dc807a545204e7a1854c33',
'tools/clang':
Var('chromium_url') + '/chromium/src/tools/clang.git' + '@' + 'a56fd8b0a235fdc3187916fc09d1e9e37e65dcf2',
Var('chromium_url') + '/chromium/src/tools/clang.git' + '@' + '2a5ebae0f797d7ad1f27d7f20bd926ce76c29411',
'tools/luci-go': {
'packages': [
{
Expand Down

0 comments on commit cd710a3

Please sign in to comment.