Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing lock guard #39

Closed
wants to merge 1 commit into from
Closed

Fix missing lock guard #39

wants to merge 1 commit into from

Conversation

NewProggie
Copy link

This commit fixes a bug where the lock guard (for concurrently accessing
the same scope from different threads) had basically no effect, due to
being bound to a temporary only.

@NewProggie
Fix missing lock guard
b728156 
This commit fixes a bug where the lock guard (for concurrently accessing
the same scope from different threads) had basically no effect, due to
being bound to a temporary only.
@backes
Copy link
Member

backes commented Mar 5, 2020

Thanks for this fix. Looks legit.

Please note that we do not accept PRs via github. Please consult the official docs if you wish to contribute to v8.

In this case though, the code in question was imported from the wasm-c-api repository. That one in fact does accept Github PRs :)
So please propose the fix there directly.

@jakobkummerow FYI

@backes backes closed this Mar 5, 2020
@NewProggie NewProggie deleted the patch-1 branch March 5, 2020 08:29
billti pushed a commit to billti/v8 that referenced this pull request Apr 6, 2020
@nico-hartmann
Merged: [turbofan] Fixes Array constructor with single string argument
1f36f17 
(cherry picked from commit 86a6ce4)

No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: chromium:1034449
Change-Id: Id121b60af0c8c8621464f15aa754056cecb04595
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064985
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#66386}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078549
Cr-Commit-Position: refs/branch-heads/8.1@{v8#39}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ghost referenced this pull request in riscv-collab/v8 Jul 15, 2020
Merge branch '39-float-nan-support' into 'riscv-porting-dev'
d765215 
Resolve "test-run-machops/RunFloat32Min failed"

Closes #39

See merge request swlab/swe/v8!52
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Sep 2, 2020
@FrankYFTang
Merged: Fix minimumIntegerDigits in NumberFormat
4d0c7b3 
The resolvedOptions of Intl.NumberFormat depends on the ICU's
skeleton. sffc change the output of the wildcard from + to *
in ICU67
(unicode-org/icu@ac4540f)

Change the v8 code to use * instead.

TBR=syg@chromium.org
(cherry picked from commit 87563c3)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Bug: chromium:1108810
Change-Id: I8b0249a5bc4cc199f454c5070635100f68d1f48d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336635
Reviewed-by: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#39}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@davidben
Merged: Fix RegisterAllocationData::ResetSpillState
828f183 
TBR=bbudge@chromium.org
(cherry picked from commit 02a06c4)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I300292b6ae93e591d95cf0cc2c0c8cc08b42c6ab
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890099
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#39}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@backes
Merged: [zone] Fix peak memory accounting
cdab8b8 
When switching from atomicops to std::atomic, I introduced a bug that
makes us miss the actual peak memory consumption, and only report the
second-highest memory usage in each zone.
This CL fixes that.

TBR=​petermarshall@chromium.org

Bug: chromium:939724
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9bdab84beadc7c78488449cd5d5be6ee64601370
Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559731
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.4@{v8#39}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@joshualitt
Revert "[hole-check-elimination] Simplest possible hole check elimina…
5d914ab 
…tion"

This reverts commit 10883f5.

Bug: v8:7427, chromium:1021457
Change-Id: Ib7f54158a2030a0c427c24b108a4eb76658d3ee0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901909
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Joshua Litt <joshualitt@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#39}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@isheludko
Merged: [ptr-compr] Fix decompression functions in v8-internal.h
023e237 
Revision: 8738ab8

BUG=v8:10198,v8:9706,chromium:1045034
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=ulan@chromium.org

Change-Id: Ieeca890abf68f15a4a73834fbef3e0677fd799b0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056851
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#39}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.3.492.21
749d931 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4a009bfe2825d76f4efbcf91c741be63f43feeb3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510580
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{v8#39}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.6.303.19
c6c7950 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Idb520787ba89be93db5c3759d83d9d3c337a4fe5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690701
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.6@{v8#39}
Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1}
Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.5.288.20
b0fc3da 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7ddab11accce670c26f3a10fb0ebb467bc1c6b6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622787
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.5@{v8#39}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 8.4.371.20
dac453b 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie6c89a872af4cc5a80e34d352c32bb913cc3948a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309291
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#39}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
@marjakh
Merged: [super IC] Fix a receiver vs lookup start object confusion bug
d975d62 
(cherry picked from commit 387c803)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Tbr: ishell@chromium.org
Bug: chromium:1203122
Change-Id: I34f2dfae082cab24ef92dd627bc64e78b889b9ca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871448
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#39}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
BenPope pushed a commit to BenPope/v8 that referenced this pull request Dec 10, 2021
Version 9.6.180.20
2fa3b13 
Change-Id: Ic173ec8154de1d4134b47b7958a8fb3917db328d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3311129
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#39}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@backes
Merged: [arm] Reset pending constant pool information on abortion
549fd86 
This avoids a DCHECK failure if we continue using the Assembler after
code generation abortion. Even though it might not be the best style to
still call methods on the Assembler after abortion, it's not a problem
apart from the firing DCHECK, so we apply this simple fix instead of
making sure to really abort everything immediately.

TBR=leszeks@chromium.org

(cherry picked from commit 66f5de1)

Bug: chromium:1228720, chromium:1217074
Change-Id: Ie0adfd50399b8725e40b2bb43839ff3c7c4623f4
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3035085
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#39}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@thibaudmichaud
[wasm] Fix and stage exception handling
4fc9ba8 
Back-merge the following commits and stage exception handling:

[wasm][eh] Fix delegate opcode
https://chromium-review.googlesource.com/c/v8/v8/+/2632604
[wasm][eh] Update delegate validation rules
https://chromium-review.googlesource.com/c/v8/v8/+/2656318
[wasm][eh] Fix catch_all encoding
https://chromium-review.googlesource.com/c/v8/v8/+/2674007
[wasm][eh] Misc fixes found by local fuzzing
https://chromium-review.googlesource.com/c/v8/v8/+/2692688
[wasm][eh] Implicit rethrow after unwind
https://chromium-review.googlesource.com/c/v8/v8/+/2696662
[wasm][eh] Update catch_all encoding
https://chromium-review.googlesource.com/c/v8/v8/+/2699258
[wasm][eh] Fix merge with phi in delegate
https://chromium-review.googlesource.com/c/v8/v8/+/2707167

R=clemensb@chromium.org

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Bug: v8:11489
Change-Id: I357acb659b5df7c23dbcae1ec0cb7c92f44c4cbc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712785
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#39}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@mi-ac
Whitespace change to test CQ
0ad89df 
Bug: chromium:569479
Change-Id: I3e038209b2a87b63a41817eac179eccbcc25afe7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199882
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#39}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.5.172.20
9310dae 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic66a17876fa46d9cbeca48e5f6a9ab02b493e16c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218786
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#39}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.6.395.20
58bdafe 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I49219925e9ff21e0e5c9bcea313b98bc4c9bf245
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503882
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#39}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@miladfarca
Merged: PPC: clear VXCVI before doing a conversion
85edf5d 
Revision: 5fe919f

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=junyan@redhat.com

Bug: v8:13178
Change-Id: I087fc135f2cc3d72386a25ff28cbd44259e822a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3826054
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: Junliang Yan <junyan@redhat.com>
Cr-Commit-Position: refs/branch-heads/10.4@{v8#39}
Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1}
Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Merged: [heap] Improve ephemeron processing
ef8c804 
(Cherry-pick to M93.)

Refactor code such that the linear algorithm is actually executed
outside the method for the fixpoint iteration. Also added a CHECK
which verifies that iterating the ephemerons one more time results in
no further marked objects.

Also force another iteration when ProcessMarkingWorklist() processed
some object. In such cases we need to re-process all ephemerons
otherwise ephemeron semantics might be broken.

(cherry picked from commit 1054ee7)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Bug: chromium:1252918
Change-Id: I9123dda50e34227a04825fd8b3172368286cc76f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200290
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Owners-Override: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.3@{v8#39}
Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1}
Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@GeorgNeis
Merged: [turbofan] Harden ArrayPrototypePop and ArrayPrototypeShift
619083c 
Revision: d4aafa4

TBR=glazunov@chromium.org
BUG=chromium:1198696
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I1840ffabbed3a3caab75b0abea1d37d9ed446d3f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2833911
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#39}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.7.106.19
41de661 
Change-Id: I5e0ab7daa109fde98a3ee07869375d30ddbc658b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398814
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{v8#39}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@zjiaz
Merged: [mips64][builtins] Fix removing all arguments from the stack
261c1a1 
The sp register's value should be modified to drop all the args
from the stack.
(cherry picked from commit 8557840)

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If68f606c38cf7249f3e215716e47b190c874eba7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2524417
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#39}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@mi-ac
[test] Upgrade Windows ia32 testing to Win10
bc57bc7 
Bug: chromium:1413661
Change-Id: Ib5731db33a51b2a9fbb64ebc81e90a5d8bce2f10
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4342395
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.0@{v8#39}
Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1}
Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@syg
[M102-LTS] Reland "[Promise.any] Fix errors allocation"
add0f3e 
M102 merge issues:
  Conflicts on tools/v8heapconst.py; Reverted the conflicting
  changes and generated a new v8heapconst.py following the
  tests/mkgrokdump/README instructions

This is a reland of commit e08fa94

Changes since revert:

Use max(remainingElements - 1, index + 1) instead of index + 1 as
newCapacity computation to avoid excessive allocations causing the
timeout.

Original change's description:
> [Promise.any] Fix errors allocation
>
> Bug: chromium:1379054
> Change-Id: Ibfcdd4ddc3c9a26471094074c8e7810d93abc898
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3988924
> Commit-Queue: Marja Hölttä <marja@chromium.org>
> Auto-Submit: Shu-yu Guo <syg@chromium.org>
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83968}

(cherry picked from commit 8b35091)

Bug: chromium:1379054
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ic788b8d0b42f4e24eaf8b2f2d05b24390fda247b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3990627
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#83987}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4020423
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#39}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Merged: Reland "[regexp] Handle empty ranges in unicode sets"
b579b43 
This is a reland of commit 91fce33

Changes since revert:
- Skip added test in no-internalization builds.

Original change's description:
> [regexp] Handle empty ranges in unicode sets
>
> If a unicode set operation contains only an empty range, we generated a
> set expression without operands. However the expression should match
> nothing, so add the special operand not matching anything instead.
>
> Bug: chromium:1437346
> Change-Id: I8dd58884aaf6915277c80effbda43ea715049146
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4474547
> Commit-Queue: Patrick Thier <pthier@chromium.org>
> Reviewed-by: Jakob Linke <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#87257}

Bug: chromium:1437346
(cherry picked from commit cb8697b)

Change-Id: I82c3262def6e78e403737507fb9ac25851550fdc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4488910
Reviewed-by: Francis McCabe <fgm@chromium.org>
Commit-Queue: Francis McCabe <fgm@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#39}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Revert "Merged: Reland "[regexp] Handle empty ranges in unicode sets""
462a9b3 
This reverts commit b579b43.

Reason for revert: Don't merge to extended stable before regular stable release (See bug for details)

Original change's description:
> Merged: Reland "[regexp] Handle empty ranges in unicode sets"
>
> This is a reland of commit 91fce33
>
> Changes since revert:
> - Skip added test in no-internalization builds.
>
> Original change's description:
> > [regexp] Handle empty ranges in unicode sets
> >
> > If a unicode set operation contains only an empty range, we generated a
> > set expression without operands. However the expression should match
> > nothing, so add the special operand not matching anything instead.
> >
> > Bug: chromium:1437346
> > Change-Id: I8dd58884aaf6915277c80effbda43ea715049146
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4474547
> > Commit-Queue: Patrick Thier <pthier@chromium.org>
> > Reviewed-by: Jakob Linke <jgruber@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#87257}
>
> Bug: chromium:1437346
> (cherry picked from commit cb8697b)
>
> Change-Id: I82c3262def6e78e403737507fb9ac25851550fdc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4488910
> Reviewed-by: Francis McCabe <fgm@chromium.org>
> Commit-Queue: Francis McCabe <fgm@chromium.org>
> Cr-Commit-Position: refs/branch-heads/11.2@{v8#39}
> Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
> Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}

Bug: chromium:1437346
Change-Id: I8fe292efb2a1c5faf00c074844f0d1b116639c6a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4491843
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#41}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@mi-ac
Manually roll build on 10.6 to include windows infra fix
cd710a3 
Roll /build:
https://chromium.googlesource.com/chromium/src/build/+log/339f8c6..6180903f

This includes https://crrev.com/c/3874828 which fixes flaky
compilation problems seen on the 10.6 V8 trybots:
https://ci.chromium.org/ui/p/v8/builders/try/v8_win_compile_dbg/b8800699999726054577/overview

This also rolls buildtools, libcxx and clang, since they have
dependencies with changes on /build.

This deps updates do not affect the Chrome release as it only updates
deps used to build V8 stand-alone, not V8 in Chrome.

This also also disables the extra-semi check which was enabled in the
same roll as otherwise a lot of source fixes need to be merged, too.

Bug: chromium:1337238
Change-Id: I92c74716fe36811761296e3bad1afe68e05beec8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3941885
Reviewed-by: Liviu Rau <liviurau@google.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#39}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.7.193.20
39f6481 
Change-Id: I4c5ca394e3e3cc6d4bb5e2392825cc213180334e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4006734
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.7@{v8#39}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 9, 2023
@LeszekSwirski
Merged: [maglev] Compare tagged values when comparing Smis
4133c2c 
Revision: bf6aa50

BUG=v8:7700, chromium:1440723
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=verwaest@chromium.org

Change-Id: Idfeff2d407c9b49714b7aaf75bcaf15466dc8a2d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556326
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#39}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 26, 2023
@manoskouk
[wasm-gc] Use wasm-null as default value for wasm reference types
356259e 
(cherry picked from commit b947905)

Bug: v8:7748, chromium:1466183
Change-Id: I6d7de33e0cec37747045269f441e65f7a482dd4f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4701553
Auto-Submit: Manos Koukoutos <manoskouk@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#89060}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4714687
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#39}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 15, 2023
Version 11.6.189.22
47bf74e 
Change-Id: I0f4878bc1cfdab2cd8ac6c0dc49da7d770b6028e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4864262
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.6@{v8#39}
Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3}
Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Oct 1, 2023
@zjiaz
Merged: [loong64][mips64][builtins] Remove a redundant and wrong debu…
21689a8 
…g check

The 'EnterFrame' function of loong64 and mips64 port doesn't push
context pointer on the stack.

Bug: v8:14340

(cherry picked from commit ab15dc3)

Change-Id: I5ef106a4f6a4d9485a149c2511566d3375e849a4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4899639
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Commit-Queue: Lutz Vahl <vahl@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#39}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 14, 2024
Merged: [codegen] Install BytecodeArray last in SharedFunctionInfo
83b0567 
Maglev assumes that when a SharedFunctionInfo has a BytecodeArray,
then it should also have FeedbackMetadata. However, this may not
hold with concurrent compilation when the SharedFunctionInfo is
re-compiled after being flushed. Here the BytecodeArray was installed
on the SFI before the FeedbackMetadata and a concurrent thread could
observe the BytecodeArray but not the FeedbackMetadata.

Drive-by: Reset the age field before setting the BytecodeArray as
well. This ensures that the concurrent marker will not observe the
old age for the new BytecodeArray.

Bug: chromium:1507412
(cherry picked from commit 46cb67e)

Change-Id: I7b876a5195ed16ae94ca9ffbca0fb51cfdb5e809
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5180368
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#39}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Feb 27, 2024
Version 12.2.281.20
54fa1c3 
Change-Id: I4afdf1ff3234f950aaf9c2073014298e1d331eef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5324064
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.2@{#39}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Mar 13, 2024
Version 12.0.267.20
f199552 
Change-Id: I2e8d96bf217d0db15c8ae23d48477fc933e019a6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5365127
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.0@{#39}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request May 22, 2024
Version 12.4.254.20
cc9dc1e 
Change-Id: I75915aedfe374d3aa4dc6aded5e0a45b43f0217d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5559885
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.4@{#39}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot pushed a commit that referenced this pull request Jun 21, 2024
Version 12.6.228.21
1a2f876 
Change-Id: Ief85747e2b5f6e4b6f7e92f8464b4d2001f78fb9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5646589
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#39}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Aug 21, 2024
Version 12.8.374.20
3b3e2ea 
Change-Id: Idd4c095893c899af33feaf41c17627e2d30ed7d0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5800815
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#39}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 26, 2024
Version 12.7.224.20
daea53b 
Change-Id: I7a6cad7c47409d7af8f5e0cbef753bebdad025be
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5813662
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.7@{#39}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Sep 23, 2024
@isheludko
Merged: [parser] Fix initializer ids w/ computed property names
bd22ebd 
Move the initializer id before the computed property name ids.

Bug: 363538434
(cherry picked from commit 8068f48)


Merged: [parser] Fix parse errors in static computed class properties

Otherwise we'll try to rewrite a FailureExpression

(cherry picked from commit 3b1adc1)

Bug: 366323452
Change-Id: I1c172effc29ab593545700d79a10cd2aecaa6112
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5877006
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.9@{#39}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Nov 26, 2024
@backes
Merged: [liftoff] Fix clobbered scratch register
e088d9d 
`GetMemOp` returns an `Operand` which can contain `kScratchRegister`. We
should hence not clobber that register until after the last use of the
`Operand`.

This CL changes the scratch register to `kScratchRegister2` which has
much fewer uses, and in particular none which collides with `GetMemOp`.

R=mliedtke@chromium.org

Bug: 378779897
(cherry picked from commit 57a017e)

Change-Id: I43a52d675064dbec8828cb00cb6dcf3287b9dbbf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6050018
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/branch-heads/13.0@{#39}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Dec 11, 2024
Version 13.2.152.20
39ac7ad 
Version incremented at https://cr-buildbucket.appspot.com/build/8728857298770794705

Change-Id: I3d6364f83ff2843a222a2ccf6ddc76e294279e2e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6087976
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#39}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Dec 16, 2024
Version 13.1.201.20
2652ab9 
Version incremented at https://cr-buildbucket.appspot.com/build/8728365243589440721

Change-Id: Icdf5a9d3fe584273dfb76d70517cfd39b22b6d03
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6096718
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.1@{#39}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NewProggie @backes