Add Color class from tagcloud hexo helper

[segayuu]

Agenda

tagcloud helper depends on the Color inner class. This class is reusable but is not currently tested alone.
Therefore, after porting to hexo-util, we separate tagcloud-dependent code from the original test. This improves the maintainability.

Clone

$ git clone https://github.com/segayuu/hexo-util
$ cd hexo-util
$ git fetch
$ git checkout Add-Color

Test

$ npm install
$ npm run test

Related

https://github.com/hexojs/hexo/blob/3.8.0/lib/plugins/helper/tagcloud.js
https://github.com/hexojs/hexo/blob/3.8.0/test/scripts/helpers/tagcloud.js

[tcrowe]

That looks interesting, @segayuu! Is it possible you can add more information? Maybe also provide the code to clone & test?

[segayuu]

Thank @tcrowe !

That looks interesting, @segayuu! Is it possible you can add more information? Maybe also provide the code to clone & test?

The PR text has been added (though it was originally 0 characters).

[yoshinorin]

@tcrowe
It's just migrate from current hexo source code.

@segayuu
My understanding, we need following procedure. Is it correct?

1. Merge this PR
2. Publish new hexo-util
3. Update hexo's hexo-util dependency & delete current hexo source code.
4. Announce breaking change & create migration guide for users.

[yoshinorin]

Btw, reported an issue about tagcloud hexojs/hexo#3622
We might be better to investigate it before merge this.

[segayuu]

Thank @yoshinorin !
The procedure you suggested is basically correct, but only the fourth one is unnecessary.
The reason is that the Color class before PR is an inner class, is not exposed as a module, and has no way to access it (this is one of the purpose of PR).
From the user's point of view, it is not a Breaking Change, as it just added an API(it is necessary to fix it as a bug if its behavior changes).

Btw, reported an issue about tagcloud hexojs/hexo#3622
We might be better to investigate it before merge this.

I did not know the issue, thank you!
However, this is the code related to the tagcloud() and the Hexo class, not to the Color class itself.

[yoshinorin]

@segayuu

However, this is the code related to the tagcloud() and the Hexo class, not to the Color class itself.

OK. Understood 😃

IMHO we might as well include this PR to hexo v4. How do you think?
If yes, we should review & merge this PR & release a new version of hexo-util before release hexo v4.

hexojs/hexo#3508

[segayuu]

@yoshinorin I agree with your opinion! 😆

[tomap]

LGTM

[tomap]

@hexojs/core anyone wants to add something or we can merge?

[curbengh]

I suggest to rebase to include test in node 8-12.

[segayuu]

@curbengh Since rebase was done and a new error was corrected, there was no problem with merge.

[coveralls]

Coverage decreased (-1.1%) to 95.214% when pulling 6d9df36 on segayuu:Add-Color into ab30d63 on hexojs:master.