Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong calculation of categories / tags count #3622

Closed
stevenjoezhang opened this issue Jul 13, 2019 · 0 comments · Fixed by #3624
Closed

Wrong calculation of categories / tags count #3622

stevenjoezhang opened this issue Jul 13, 2019 · 0 comments · Fixed by #3624
Labels
enhancement New feature or request

Comments

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Jul 13, 2019 •
edited
Loading

For BUG

See: #1502 #2925

Categories / tags of draft are displayed / counted in non-draft generate.

In hexo-theme-next, we tried to filter out the categories / tags in the draft, but this caused performance issues:
theme-next/hexo-theme-next#42
theme-next/hexo-theme-next#87

Then I found this in tagcloud.js:

hexo/lib/plugins/helper/tagcloud.js

Lines 195 to 196 in b6394c7

// Ignore tags with zero posts
tags = tags.filter(tag => tag.length);

Can this filter be applied to this.site.tags?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore categories / tags with zero posts
2 participants
@yoshinorin @stevenjoezhang