Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore categories / tags with zero posts #3624

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Ignore categories / tags with zero posts #3624

merged 1 commit into from
Oct 4, 2019

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Jul 13, 2019 •
edited
Loading

What does it do?

Issue resolved: #3622

Current behaviour

Categories / tags of draft are displayed / counted in non-draft generate.

In hexo-theme-next, we tried to filter out the categories / tags in the draft, but this caused performance issues.

More information:
theme-next/hexo-theme-next#42
theme-next/hexo-theme-next#87

How to test

git clone -b master https://github.com/stevenjoezhang/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@stevenjoezhang stevenjoezhang mentioned this pull request Jul 13, 2019
Merged
15 tasks
@coveralls
Copy link

coveralls commented Jul 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 97.309% when pulling b62c13d on stevenjoezhang:master into ffe4eaa on hexojs:master.

stevenjoezhang
stevenjoezhang commented Jul 13, 2019
View reviewed changes
lib/hexo/index.js Outdated Show resolved Hide resolved
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 16, 2019
Merged
15 tasks
@jiangtj jiangtj mentioned this pull request Aug 15, 2019
Closed
@jiangtj
Copy link
Member

jiangtj commented Aug 15, 2019

Or add a new locals？ 🤔
https://github.com/jiangtj/hexo-theme-cake/blob/master/scripts/events/lib/fix-categories-tags.js

@curbengh curbengh added this to the v4.0.0 milestone Sep 23, 2019
@curbengh
Copy link
Contributor

I can confirm this fixes the issue. Let's wait for #3728 first to fix failing test.

@curbengh
Copy link
Contributor

#3728 has been merged. Please rebase.

@stevenjoezhang
Copy link
Member Author

Done

@SukkaW
Copy link
Member

SukkaW commented Oct 3, 2019

Is it good to merge then?

@SukkaW SukkaW closed this Oct 3, 2019
@SukkaW SukkaW reopened this Oct 3, 2019
@SukkaW SukkaW closed this Oct 3, 2019
@SukkaW SukkaW reopened this Oct 3, 2019
@curbengh
Copy link
Contributor

curbengh commented Oct 4, 2019

LGTM

@SukkaW SukkaW merged commit 71d10fd into hexojs:master Oct 4, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@stevenjoezhang
refactor: ignore categories / tags with zero posts (hexojs#3624)
c2dad09
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 23, 2020
Merged
15 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 28, 2022
Merged
2 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Apr 11, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Wrong calculation of categories / tags count
5 participants
@stevenjoezhang @coveralls @jiangtj @curbengh @SukkaW