Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #42, #87 #976

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Revert #42, #87 #976

merged 2 commits into from
Aug 31, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

Should we merge this PR or wait for hexojs/hexo#3624 ?

@ivan-nginx
Copy link
Member

I think we can wait a little. I have some idea about it.

@stevenjoezhang
Copy link
Contributor Author

This bug only appears when the user uses the _draft folder. We can recommend not using _draft in the documentation.

@ivan-nginx
Copy link
Member

This bug only appears when the user uses the _draft folder. We can recommend not using _draft in the documentation.

Yep, good idea.

@stevenjoezhang stevenjoezhang modified the milestones: v8.0.0, v7.4.1 Aug 31, 2019
@stevenjoezhang stevenjoezhang merged commit c566f9f into master Aug 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the count branch August 31, 2019 18:34
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants