Revert "Avoid recalculating the number of tags and categories" #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8e2aef.
auto-assign
bot
requested review from
ivan-nginx,
maple3142,
sli1989 and
stevenjoezhang
stevenjoezhang
approved these changes
Jul 12, 2019
8 tasks
|
Do you know why this bug only appears in the first generation? Is this a Hexo bug? (about |
|
Or we just report this problem to Hexo, to let site.categories.length and site.tags.length return the correct results |
Maybe cache will work fine, I will try again. |
|
Seems Hexo ignores these issues: |
|
New issue opened: hexojs/hexo#3622 |
|
Only |
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
…next#954)" (theme-next#969) This reverts commit a8e2aef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #954
In
generateBefore, we can't get the count....In
template_locals, loop much times...Revert this submit, the best way is not use _draft, and then don't calculate them, if you have many tags or categoriesMaybe cache, I will try again