Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(partial): enhance caching #4146

Closed
wants to merge 1 commit into from
Closed

perf(partial): enhance caching #4146

wants to merge 1 commit into from

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 23, 2020

What does it do?

  • Cache view based on name (Every partial should only have unique name).
  • Avoid unnecessary Object.assign for partial being cached by fragment_cache

How to test

git clone -b optimize-partial-rendering https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team February 23, 2020 09:41
@SukkaW SukkaW changed the title refactor(partial): enhance caching perf(partial): enhance caching Feb 23, 2020
@SukkaW SukkaW closed this Mar 29, 2020
@stevenjoezhang
Copy link
Member

Ref #3897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukkaW @stevenjoezhang