perf(partial): enhance caching

lib/plugins/helper/partial.js

@@ -1,35 +1,50 @@
 'use strict';
 
 const { dirname, join } = require('path');
+const { Cache } = require('hexo-util');
+const viewCache = new Cache();
 
 module.exports = ctx => function partial(name, locals, options = {}) {
   if (typeof name !== 'string') throw new TypeError('name must be a string!');
 
-  const { cache } = options;
-  const viewDir = this.view_dir;
-  const currentView = this.filename.substring(viewDir.length);
-  const path = join(dirname(currentView), name);
-  const view = ctx.theme.getView(path) || ctx.theme.getView(name);
-  const viewLocals = { layout: false };
+  let view;
+  if (viewCache.has(name)) {
+    view = viewCache.get(name);
+  } else {
+    const viewDir = this.view_dir;
+    const currentView = this.filename.substring(viewDir.length);
+    const path = join(dirname(currentView), name);
+    view = ctx.theme.getView(path) || ctx.theme.getView(name);
 
-  if (!view) {
-    throw new Error(`Partial ${name} does not exist. (in ${currentView})`);
-  }
+    if (!view) {
+      throw new Error(`Partial ${name} does not exist. (in ${currentView})`);
+    }
 
-  if (options.only) {
-    Object.assign(viewLocals, locals);
-  } else {
-    Object.assign(viewLocals, this, locals);
+    viewCache.set(name, view);
   }
 
-  // Partial don't need layout
-  viewLocals.layout = false;
+  const { cache, only } = options;
+
+  const viewRender = () => {
+    const viewLocals = { layout: false };
+
+    if (only) {
+      Object.assign(viewLocals, locals);
+    } else {
+      Object.assign(viewLocals, this, locals);
+    }
+
+    // Partial don't need layout
+    viewLocals.layout = false;
+
+    return view.renderSync(viewLocals);
+  };
 
   if (cache) {
     const cacheId = typeof cache === 'string' ? cache : view.path;
 
-    return this.fragment_cache(cacheId, () => view.renderSync(viewLocals));
+    return this.fragment_cache(cacheId, viewRender);
   }
 
-  return view.renderSync(viewLocals);
+  return viewRender();
 };

test/scripts/helpers/partial.js

@@ -57,22 +57,22 @@ describe('partial', () => {
   });
 
   it('locals', () => {
-    hexo.theme.setView('test.swig', '{{ foo }}');
+    hexo.theme.setView('test1.swig', '{{ foo }}');
 
-    partial('test', {foo: 'bar'}).should.eql('bar');
+    partial('test1', {foo: 'bar'}).should.eql('bar');
   });
 
   it('cache', () => {
-    hexo.theme.setView('test.swig', '{{ foo }}');
+    hexo.theme.setView('test1.swig', '{{ foo }}');
 
-    partial('test', {foo: 'bar'}, {cache: true}).should.eql('bar');
-    partial('test', {}, {cache: true}).should.eql('bar');
+    partial('test1', {foo: 'bar'}, {cache: true}).should.eql('bar');
+    partial('test1', {}, {cache: true}).should.eql('bar');
   });
 
   it('only', () => {
-    hexo.theme.setView('test.swig', '{{ foo }}{{ bar }}');
+    hexo.theme.setView('test2.swig', '{{ foo }}{{ bar }}');
 
-    partial('test', {bar: 'bar'}, {only: true}).should.eql('bar');
+    partial('test2', {bar: 'bar'}, {only: true}).should.eql('bar');
   });
 
   it('a partial in another partial', () => {