Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(test): Useful sinon.assert #4164

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Feb 29, 2020

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested review from SukkaW and curbengh February 29, 2020 12:34
@SukkaW
Copy link
Member

SukkaW commented Feb 29, 2020

IMHO, since Hexo has complicate unit tests, it is better to retain test/index.js. Also, using * might causes different behaviors between enviroments.

@SukkaW SukkaW merged commit 8284d9f into hexojs:master Mar 3, 2020
@segayuu segayuu deleted the refactor-test branch March 3, 2020 16:09
@segayuu segayuu mentioned this pull request Jul 6, 2020
2 tasks
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants