Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace sinon#assert #4401

Merged
merged 1 commit into from
Jul 6, 2020
Merged

test: replace sinon#assert #4401

merged 1 commit into from
Jul 6, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 6, 2020

What does it do?

Replace sinon#assert with Chai.Assertion.LanguageChain.

How to test

git clone -b test-replace-sinonAssert https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team July 6, 2020 06:27
@SukkaW SukkaW merged commit 7520113 into hexojs:master Jul 6, 2020
@segayuu
Copy link
Contributor

segayuu commented Jul 6, 2020

This PR is effectively a Revert of #4164 that was there before.
The reason I put that PR out is to show a detailed message if the assert fails.
Did you see a downside to the reliance on sinon#assert over the benefit of getting a detailed message?

@SukkaW
Copy link
Member Author

SukkaW commented Jul 6, 2020

@segayuu

Emmmm, I see. I think I should revert the PR then.

SukkaW added a commit that referenced this pull request Jul 6, 2020
@SukkaW
Revert "test: replace sinon#assert (#4401)"
5f11323 
This reverts commit 7520113.
@SukkaW SukkaW mentioned this pull request Jul 6, 2020
Merged
SukkaW added a commit that referenced this pull request Jul 10, 2020
@SukkaW
revert(#4401): "test: replace sinon#assert" (#4404)
f766caf 
This reverts commit 7520113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @segayuu @stevenjoezhang