Bump org.glassfish.expressly:expressly from 5.0.0 to 6.0.0 #2362
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
--- updated-dependencies: - dependency-name: org.glassfish.expressly:expressly dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
| @@ -32,7 +32,7 @@ io-vertx-vertx-web-client = { group = "io.vertx", name = "vertx-web-client", ver | |||
| org-apache-logging-log4j-log4j-core = { group = "org.apache.logging.log4j", name = "log4j-core", version.ref = "log4jVersion" } | |||
| org-assertj-assertj-core = { group = "org.assertj", name = "assertj-core", version.ref = "assertjVersion" } | |||
| org-ehcache-ehcache = { group = "org.ehcache", name = "ehcache", version = "3.10.8" } | |||
| org-glassfish-expressly-expressly = { group = "org.glassfish.expressly", name = "expressly", version = "5.0.0" } | |||
| org-glassfish-expressly-expressly = { group = "org.glassfish.expressly", name = "expressly", version = "6.0.0" } | |||
There was a problem hiding this comment.
hmm for this one you probably want to bump it in pair with
org-hibernate-validator-hibernate-validator = { group = "org.hibernate.validator", name = "hibernate-validator", version = "8.0.2.Final" }
expressly 5 + HV 8
expressly 6 + HV 9
with that said .... if HV is here just for tests ... you can always make it work without expressly:
hibernate/hibernate-orm@58d2239
There was a problem hiding this comment.
and if you want to keep expressly, then probably it would make sense to add it to the ignore rules for dependabot so that it would get updated in pair with HV to match the version it targets..
There was a problem hiding this comment.
Thanks, I will try to remove it for now.
There was a problem hiding this comment.
No, the test will fail without it. I will try to see what I can do with dependabot
There was a problem hiding this comment.
rigth ... you need to switch the interpolator if you want to remove the dependency... if you add the XML https://github.com/hibernate/hibernate-orm/blob/58d2239d850ad700d9348d13ca24de9ef4865887/hibernate-c3p0/src/test/resources/META-INF/validation.xml it should do the trick
There was a problem hiding this comment.
and just in case you'd want to ignore the updates, here's an example from Search 🙈😃 : https://github.com/hibernate/hibernate-search/blob/9d88f870b7e33728a70969d8eaf4f0bf27cb0137/.github/dependabot.yml#L92-L95
There was a problem hiding this comment.
I prefer to be notified when there's a new release, and ignore it if I'm not interested or doesn't work.
I think I will just create a group for validator with hibernate-validator and glassfish and evaluate case by case.
Considering that we only use it for testing, it should be fine to have a more relaxed rule for it.
I will re-evaluate if it becomes too much of a chore to keep it up to date
There was a problem hiding this comment.
Actually, I will just lock the version to 5 until we change hibernate-validator to 9
There was a problem hiding this comment.
rigth ... you need to switch the interpolator if you want to remove the dependency... if you add the XML https://github.com/hibernate/hibernate-orm/blob/58d2239d850ad700d9348d13ca24de9ef4865887/hibernate-c3p0/src/test/resources/META-INF/validation.xml it should do the trick
By the way... why is this not the default?
There was a problem hiding this comment.
it has to do with the spec: https://jakarta.ee/specifications/bean-validation/3.1/jakarta-validation-spec-3.1#validationapi-message-defaultmessageinterpolation-expressionlanguage by default, EL must be supported.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/gradle/org.glassfish.expressly-expressly-6.0.0
branch
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)